release: remove local repository pointing to Jenkins and tweak errors propagation in the buildkite pipelines (#205)

Author: v1v

.buildkite/release.yml

@@ -4,8 +4,8 @@ agents:
 steps:
   - label: "Run the release"
     key: "release"
-    commands: .ci/release.sh | tee release.out
-    artifact_paths: "release.out"
+    commands: .ci/release.sh
+    artifact_paths: "release.txt"
 
 notify:
   - slack:

.buildkite/snapshot.yml

@@ -4,12 +4,13 @@ agents:
 steps:
   - label: "Run the snapshot"
     key: "release"
-    commands: .ci/snapshot.sh | tee snapshot.out
+    commands: .ci/snapshot.sh
     artifact_paths:
-      - "snapshot.out"
+      - "snapshot.txt"
       - "**/target/*"
 
 notify:
   - slack:
+    if: build.state == "failed"
       channels:
         - "#apm-agent-java"

.ci/release.sh

@@ -3,10 +3,10 @@
 ##    branch_specifier
 ##    dry_run
 ##
-##  It relies on the .buildkite/hooks/pre-command so the Vault is prepared
-##  automatically by buildkite.
-
-set -e
+##  It relies on the .buildkite/hooks/pre-command so the Vault and other tooling
+##  are prepared automatically by buildkite.
+##
+set -eo pipefail
 
 # Make sure we delete this folder before leaving even in case of failure
 clean_up () {
@@ -27,5 +27,5 @@ if [[ "$dry_run" == "true" ]] ; then
   echo './mvnw release:prepare release:perform --settings .ci/settings.xml --batch-mode'
 else
   # providing settings in arguments to make sure they are propagated to the forked maven release process
-  ./mvnw release:prepare release:perform --settings .ci/settings.xml -Darguments="--settings .ci/settings.xml" --batch-mode
+  ./mvnw release:prepare release:perform --settings .ci/settings.xml -Darguments="--settings .ci/settings.xml" --batch-mode | tee release.txt
 fi

.ci/settings.xml

@@ -1,6 +1,5 @@
 <settings xmlns="http://maven.apache.org/SETTINGS/1.1.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
           xsi:schemaLocation="http://maven.apache.org/SETTINGS/1.1.0 http://maven.apache.org/xsd/settings-1.1.0.xsd">
-    <localRepository>/var/lib/jenkins/.m2/repository</localRepository>
     <pluginGroups>
         <pluginGroup>org.apache.maven.plugins</pluginGroup>
         <pluginGroup>org.codehaus.mojo</pluginGroup>

.ci/snapshot.sh

@@ -6,7 +6,7 @@
 ##  are prepared automatically by buildkite.
 ##
 
-set -e
+set -eo pipefail
 
 # Make sure we delete this folder before leaving even in case of failure
 clean_up () {
@@ -23,5 +23,5 @@ echo "--- Deploy the snapshot"
 if [[ "$dry_run" == "true" ]] ; then
   echo './mvnw -s .ci/settings.xml -Pgpg clean deploy --batch-mode'
 else
-  ./mvnw -s .ci/settings.xml -Pgpg clean deploy --batch-mode
+  ./mvnw -s .ci/settings.xml -Pgpg clean deploy --batch-mode | tee snapshot.txt
 fi