Skip to content

[Synthetics] Adjust private location docs to support base elastic-agent #3831

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
emilioalvap merged 16 commits into from
Dec 5, 2025
Merged

[Synthetics] Adjust private location docs to support base elastic-agent #3831

emilioalvap merged 16 commits into from
Dec 5, 2025

Conversation

@emilioalvap
Copy link
Contributor

@emilioalvap emilioalvap commented Nov 5, 2025

Summary

Adjust synthetics docs to support elastic-agent base image for non-browser monitors.

Relates to https://github.com/elastic/synthetics-dev/issues/402.

@emilioalvap emilioalvap requested review from a team as code owners November 5, 2025 19:58
@emilioalvap emilioalvap changed the title [Synthetics] Adjust private location docs to support base elastic-agent image [Synthetics] Adjust private location docs to support base elastic-agent Nov 5, 2025
@github-actions
Copy link

github-actions bot commented Nov 5, 2025 •
edited
Loading

🔍 Preview links for changed docs

lucabelluccini
lucabelluccini reviewed Nov 5, 2025
View reviewed changes
Copy link
Contributor

@lucabelluccini lucabelluccini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've made some suggestions as I think being more explicit as possible is the best.
Also I would recommend, for the 'default' path, to show the complete option.

There are less chances someone will have to redo the download/tutorial because they blindly copy pasted the steps without reading the warnings and then they discover they would like to run a browser monitor.

emilioalvap and others added 4 commits November 6, 2025 13:02
@emilioalvap @lucabelluccini
Update solutions/observability/synthetics/support-matrix.md
683f2da 
Co-authored-by: Luca Belluccini <luca.belluccini@elastic.co>
@emilioalvap @lucabelluccini
Update solutions/observability/synthetics/monitor-resources-on-privat…
b4019b7 
…e-networks.md

Co-authored-by: Luca Belluccini <luca.belluccini@elastic.co>
@emilioalvap @lucabelluccini
Update reference/fleet/elastic-agent-container.md
623f45d 
Co-authored-by: Luca Belluccini <luca.belluccini@elastic.co>
@emilioalvap @lucabelluccini
Apply suggestions from code review
315807a 
Co-authored-by: Luca Belluccini <luca.belluccini@elastic.co>
@emilioalvap
Copy link
Contributor Author

emilioalvap commented Nov 6, 2025

Thanks for the suggestions @lucabelluccini, I still need to add a reference to alternative elastic-agent (basic) install methods, which we will also be supporting from now on. I'll update the default tab options to show the complete variant first as you suggested

mdbirnstiehl
mdbirnstiehl reviewed Nov 6, 2025
View reviewed changes
Copy link
Contributor

@mdbirnstiehl mdbirnstiehl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left a few suggestions. Let me know if you have any questions or comments.

emilioalvap and others added 2 commits November 12, 2025 15:06
@emilioalvap @mdbirnstiehl
Apply suggestions from code review
2f5bab9 
Co-authored-by: Mike Birnstiehl <114418652+mdbirnstiehl@users.noreply.github.com>
@emilioalvap
Merge branch 'main' into synthetics-private-locations-update
1117333
@emilioalvap emilioalvap enabled auto-merge (squash) November 12, 2025 23:21
colleenmcginnis
colleenmcginnis reviewed Nov 18, 2025
View reviewed changes
Copy link
Contributor

@colleenmcginnis colleenmcginnis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left a couple minor suggestions below to make the way we refer to synthetic browser monitors in the Fleet docs more consistent with how we refer to them in the Observability docs.

@emilioalvap @colleenmcginnis
Apply suggestions from code review
220b299 
Co-authored-by: Colleen McGinnis <colleen.mcginnis@elastic.co>
@github-actions
Copy link

github-actions bot commented Nov 21, 2025 •
edited
Loading

Vale Linting Results

Summary: 2 suggestions found

💡 Suggestions (2)
File Line Rule Message
reference/fleet/elastic-agent-container.md 72 Elastic.FutureTense 'will run' might be in future tense. Write in the present tense to describe the state of the product as it is now.
solutions/observability/synthetics/monitor-resources-on-private-networks.md 61 Elastic.Acronyms 'ICMP' has no definition.

@emilioalvap
Copy link
Contributor Author

emilioalvap commented Nov 21, 2025

Thanks @colleenmcginnis and @mdbirnstiehl for the suggestions! Please review again and let me know if this is ready for merging.

@emilioalvap
Copy link
Contributor Author

emilioalvap commented Nov 28, 2025

@colleenmcginnis @mdbirnstiehl Kind reminder to review the committed changes and provide an approval if everything is Ok

colleenmcginnis
colleenmcginnis approved these changes Dec 4, 2025
View reviewed changes
Copy link
Contributor

@colleenmcginnis colleenmcginnis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@emilioalvap sorry for the delay! I left one more suggestion on the reference/fleet/elastic-agent-container.md file, but it shouldn't block this PR.

@emilioalvap @colleenmcginnis
Apply suggestions from code review
cc62549 
Co-authored-by: Colleen McGinnis <colleen.mcginnis@elastic.co>
@emilioalvap
Copy link
Contributor Author

emilioalvap commented Dec 5, 2025

@elastic/experience-docs Please provide a review as code owner, thank you!

@emilioalvap emilioalvap merged commit fed1127 into main Dec 5, 2025
7 of 8 checks passed
@emilioalvap emilioalvap deleted the synthetics-private-locations-update branch December 5, 2025 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lucabelluccini lucabelluccini lucabelluccini left review comments

@colleenmcginnis colleenmcginnis colleenmcginnis approved these changes

@mdbirnstiehl mdbirnstiehl mdbirnstiehl approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@emilioalvap @lucabelluccini @colleenmcginnis @mdbirnstiehl