Show base version if we don't get a specified version for a versioned product

Author: cotti

src/Elastic.Documentation/AppliesTo/ApplicableToYamlConverter.cs

@@ -284,7 +284,7 @@ private static void ValidateApplicabilityCollection(string key, AppliesCollectio
 
 		// Rule: Only one item per key can use greater-than syntax
 		var greaterThanItems = items.Where(a =>
-			a.Version is VersionSpec spec && spec.Kind == VersionSpecKind.GreaterThanOrEqual &&
+			a.Version is { Kind: VersionSpecKind.GreaterThanOrEqual } &&
 			a.Version != AllVersionsSpec.Instance).ToList();
 
 		if (greaterThanItems.Count > 1)
@@ -335,8 +335,8 @@ private static bool CheckVersionOverlap(VersionSpec v1, VersionSpec v2, out stri
 		var (v1Min, v1Max) = GetEffectiveRange(v1);
 		var (v2Min, v2Max) = GetEffectiveRange(v2);
 
-		var overlaps = v1Min.CompareTo(v2Max ?? new SemVersion(9999, 9999, 9999)) <= 0 &&
-						v2Min.CompareTo(v1Max ?? new SemVersion(9999, 9999, 9999)) <= 0;
+		var overlaps = v1Min.CompareTo(v2Max ?? new SemVersion(99999, 99999, 99999)) <= 0 &&
+						v2Min.CompareTo(v1Max ?? new SemVersion(99999, 99999, 99999)) <= 0;
 
 		if (overlaps)
 			message = $"Version ranges overlap.";

src/Elastic.Documentation/SemVersion.cs

@@ -8,7 +8,7 @@
 
 namespace Elastic.Documentation;
 
-public class AllVersions() : SemVersion(9999, 9999, 9999)
+public class AllVersions() : SemVersion(99999, 99999, 99999)
 {
 	public static AllVersions Instance { get; } = new();
 }

src/Elastic.Markdown/Myst/Components/ApplicabilityRenderer.cs

@@ -2,7 +2,6 @@
 // Elasticsearch B.V licenses this file to you under the Apache 2.0 License.
 // See the LICENSE file in the project root for more information
 
-using System.Diagnostics.CodeAnalysis;
 using Elastic.Documentation;
 using Elastic.Documentation.AppliesTo;
 using Elastic.Documentation.Configuration.Versions;
@@ -159,8 +158,10 @@ private static string BuildTooltipText(
 	{
 		var tooltipText = "";
 
-		tooltipText = applicability.Version is not null && applicability.Version != AllVersionsSpec.Instance
-			? applicability.Version.Min <= versioningSystem.Current
+		// Check if a specific version is provided
+		if (applicability.Version is not null && applicability.Version != AllVersionsSpec.Instance)
+		{
+			tooltipText = applicability.Version.Min <= versioningSystem.Current
 				? $"{lifecycleFull} on {applicabilityDefinition.DisplayName} version {applicability.Version.Min} and later unless otherwise specified."
 				: applicability.Lifecycle switch
 				{
@@ -174,8 +175,21 @@ or ProductLifecycle.TechnicalPreview
 					ProductLifecycle.Removed =>
 						$"We plan to remove this functionality in a future {applicabilityDefinition.DisplayName} update. Subject to change.",
 					_ => tooltipText
+				};
+		}
+		else
+		{
+			// No version specified - check if we should show base version
+			tooltipText = versioningSystem.Base.Major != AllVersionsSpec.Instance.Min.Major
+				? applicability.Lifecycle switch
+				{
+					ProductLifecycle.Removed =>
+						$"Removed in {applicabilityDefinition.DisplayName} {versioningSystem.Base.Major}.{versioningSystem.Base.Minor}.",
+					_ =>
+						$"{lifecycleFull} since {versioningSystem.Base.Major}.{versioningSystem.Base.Minor}."
 				}
-			: $"{lifecycleFull} on {applicabilityDefinition.DisplayName} unless otherwise specified.";
+				: $"{lifecycleFull} on {applicabilityDefinition.DisplayName} unless otherwise specified.";
+		}
 
 		var disclaimer = GetDisclaimer(applicability.Lifecycle, versioningSystem.Id);
 		if (disclaimer is not null)
@@ -246,8 +260,15 @@ private static string BuildBadgeLifecycleText(
 	/// </summary>
 	private static string GetBadgeVersionText(VersionSpec? versionSpec, VersioningSystem versioningSystem)
 	{
+		// When no version is specified, check if we should show the base version
 		if (versionSpec is null || versionSpec == AllVersionsSpec.Instance)
+		{
+			if (versioningSystem.Base.Major != AllVersionsSpec.Instance.Min.Major)
+				return $"{versioningSystem.Base.Major}.{versioningSystem.Base.Minor}+";
+
+			// Otherwise, this is an unversioned product, show no version
 			return string.Empty;
+		}
 
 		var kind = versionSpec.Kind;
 		var min = versionSpec.Min;