Potential fix for pull request finding 'Nested 'if' statements can be combined'

lcawl · github-code-quality[bot] · web-flow · commit 8a2ff075d94b · 2025-12-10T17:01:49.000-08:00
Co-authored-by: Copilot Autofix powered by AI &lt;223894421+github-code-quality[bot]@users.noreply.github.com&gt;
diff --git a/src/services/Elastic.Documentation.Services/ChangelogService.cs b/src/services/Elastic.Documentation.Services/ChangelogService.cs
@@ -41,13 +41,12 @@ Cancel ctx
 			}
 
 			// Validate that if PR is just a number, owner and repo must be provided
-			if (!string.IsNullOrWhiteSpace(input.Pr) && int.TryParse(input.Pr, out _))
+			if (!string.IsNullOrWhiteSpace(input.Pr) 
+				&& int.TryParse(input.Pr, out _) 
+				&& (string.IsNullOrWhiteSpace(input.Owner) || string.IsNullOrWhiteSpace(input.Repo)))
 			{
-				if (string.IsNullOrWhiteSpace(input.Owner) || string.IsNullOrWhiteSpace(input.Repo))
-				{
-					collector.EmitError(string.Empty, "When --pr is specified as just a number, both --owner and --repo must be provided");
-					return false;
-				}
+				collector.EmitError(string.Empty, "When --pr is specified as just a number, both --owner and --repo must be provided");
+				return false;
 			}
 
 			// If PR is specified, try to fetch PR information and derive title/type

Original file line number	Diff line number	Diff line change
`@@ -41,13 +41,12 @@ Cancel ctx`
`41`	`41`	`}`
`42`	`42`
`43`	`43`	`// Validate that if PR is just a number, owner and repo must be provided`
`44`		`- if (!string.IsNullOrWhiteSpace(input.Pr) && int.TryParse(input.Pr, out _))`
	`44`	`+ if (!string.IsNullOrWhiteSpace(input.Pr)`
	`45`	`+ && int.TryParse(input.Pr, out _)`
	`46`	`+ && (string.IsNullOrWhiteSpace(input.Owner) \|\| string.IsNullOrWhiteSpace(input.Repo)))`
`45`	`47`	`{`
`46`		`- if (string.IsNullOrWhiteSpace(input.Owner) \|\| string.IsNullOrWhiteSpace(input.Repo))`
`47`		`- {`
`48`		`- collector.EmitError(string.Empty, "When --pr is specified as just a number, both --owner and --repo must be provided");`
`49`		`- return false;`
`50`		`- }`
	`48`	`+ collector.EmitError(string.Empty, "When --pr is specified as just a number, both --owner and --repo must be provided");`
	`49`	`+ return false;`
`51`	`50`	`}`
`52`	`51`
`53`	`52`	`// If PR is specified, try to fetch PR information and derive title/type`