Adopting a few review suggestions

Author: cotti

src/Elastic.Documentation/AppliesTo/ApplicabilitySelector.cs

@@ -30,8 +30,7 @@ public static Applicability GetPrimaryApplicability(IEnumerable<Applicability> a
 		};
 
 		var availableApplicabilities = applicabilityList
-			.Where(a => a.Version is null || a.Version is AllVersionsSpec ||
-					   (a.Version is VersionSpec vs && vs.Min <= currentVersion))
+			.Where(a => a.Version is null || a.Version is AllVersionsSpec || a.Version.Min <= currentVersion)
 			.ToList();
 
 		if (availableApplicabilities.Count != 0)
@@ -43,8 +42,7 @@ public static Applicability GetPrimaryApplicability(IEnumerable<Applicability> a
 		}
 
 		var futureApplicabilities = applicabilityList
-			.Where(a => a.Version is not null && a.Version is not AllVersionsSpec &&
-					   a.Version is VersionSpec vs && vs.Min > currentVersion)
+			.Where(a => a.Version is not null && a.Version is not AllVersionsSpec && a.Version.Min > currentVersion)
 			.ToList();
 
 		if (futureApplicabilities.Count != 0)

src/Elastic.Documentation/AppliesTo/ApplicableToYamlConverter.cs

@@ -294,15 +294,13 @@ private static void ValidateApplicabilityCollection(string key, AppliesCollectio
 		}
 
 		// Rule: In a range, the first version must be less than or equal the last version
-		foreach (var item in items)
+		foreach (var item in items.Where(a => a.Version is { Kind: VersionSpecKind.Range }))
 		{
-			if (item.Version is { Kind: VersionSpecKind.Range } spec)
+			var spec = item.Version!;
+			if (spec.Min.CompareTo(spec.Max!) > 0)
 			{
-				if (spec.Min.CompareTo(spec.Max!) > 0)
-				{
-					diagnostics.Add((Severity.Warning,
-						$"Key '{key}', {item.Lifecycle}: Range has first version ({spec.Min.Major}.{spec.Min.Minor}) greater than last version ({spec.Max!.Major}.{spec.Max.Minor})."));
-				}
+				diagnostics.Add((Severity.Warning,
+					$"Key '{key}', {item.Lifecycle}: Range has first version ({spec.Min.Major}.{spec.Min.Minor}) greater than last version ({spec.Max!.Major}.{spec.Max.Minor})."));
 			}
 		}