feat: use pebblegozstd tags everywhere #19814
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation/summary
The apm-server binary is built as a static Go binary with CGO disabled, so it relies on the pure Go zstd implementation. However, our test suite runs with CGO enabled (required for the race detector), which means it previously exercised a different code path.
To align the test builds with the production binary, we now compile the tests with the pebblegozstd build tag. This forces Pebble to use the Go ZSTD library in both environments.
The same tag also affects the FIPS build, which previously depended on the C-based zstd library due to Microsoft’s Go fork requiring CGO. Switching to the Go implementation brings the FIPS build in line with the standard binary and enhances security by eliminating the C-based zstd dependency.
Checklist
For functional changes, consider:
How to test these changes
make test
Related issues
Closes #19626