This repository was archived by the owner on Jun 12, 2018. It is now read-only.
Fix Pong payload #103
Open
Fix Pong payload #103
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paresy
pushed a commit
to paresy/Simple-WebSocket-Server
that referenced
this pull request
Nov 26, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to the Websocket RFC, a Pong frame sent in response to a Ping frame must have identical "Application data" as found in the message body of the Ping frame being replied to.
The current implementation always sends an empty Pong message. Problems arise when communicating with other implementations conforming to the RFC, which would discard an empty Pong message, in case the original Ping message wasn't empty.
This pull request contains a fix to this issue.