-
Notifications
You must be signed in to change notification settings - Fork 463
Feature: Password generation and show/hide functionality #156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Feature: Password generation and show/hide functionality #156
Conversation
|
@Serafeim-Katsaros I think, it's better to generate a password using JS instead of Python |
Thank you for your feedback. I completely understand your point --- generating the password directly in JavaScript would simplify the process and remove the need for an extra backend request. I can update the implementation so the random code is generated client-side using Web Crypto API for security. Would you prefer this approach? |
Yep, sounds good |
I've updated the implementation to generate passwords entirely on the client-side using the Web Crypto API and the AJAX calls have been removed. Please have a look when you get a chance. Thanks! |
|
Thanks. Can you check locale files and add if there's a need to add them? |
I’ve updated the locale files and added the new strings for the “Generate Password” and “Show/Hide password” buttons. They are now translatable in all supported languages. |
egorsmkv
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
|
Hi! I’ve made the requested changes. |
Description
The password is now generated fully client-side using the Web Crypto API (crypto.getRandomValues) without any backend code or AJAX requests.
Why this PR is needed:
Generate Password Details:
Screenshots:
Notes: