fix unhandled error when streaming data on WebGL platform

Author: edricwilliem

Assets/FirebaseREST/Database/DatabaseReference.cs

@@ -274,10 +274,16 @@ void DisposedUnityWebRequestIfNoReferences()
             {
 #if UNITY_WEBGL
                 if (esGL != null)
+                {
                     esGL.Close();
+                    esGL = null;
+                }
 #else
-            if (webReq != null)
-                webReq.Dispose();
+                if (webReq != null)
+                {
+                    webReq.Dispose();
+                    webReq = null;
+                }
 #endif
             }
         }

Assets/FirebaseREST/Database/FirebaseDatabase.cs

@@ -129,26 +129,19 @@ public static void EventSourceErrorCallback(int id, string error)
             Debug.Log("Unity ES Error");
             if (esWebGLMap.ContainsKey(id))
             {
-                esWebGLMap[id].Close();
                 if (esWebGLMap[id].EventSourceError != null)
                     esWebGLMap[id].EventSourceError(new FirebaseEventSourceErrorArgs(error));
+                esWebGLMap[id].Close();
+                esWebGLMap[id] = null;
                 esWebGLMap.Remove(id);
             }
         }
 
-        [MonoPInvokeCallback(typeof(_EventSourceClosedArgs))]
-        public static void EventSourceClosedCallback(int id)
-        {
-            Debug.Log("Unitt ES Closed");
-            if (esWebGLMap.ContainsKey(id))
-                esWebGLMap.Remove(id);
-        }
-
         [DllImport("__Internal")]
         static extern int CreateEventSource(string urlPtr, bool withCredentials, _EventSourceOpenArgs onOpen,
              _EventSourceMessageArgs onMessage, _EventSourceErrorArgs onError);
 
         [DllImport("__Internal")]
-        static extern void CloseEventSource(int id, _EventSourceClosedArgs onClosed);
+        static extern void CloseEventSource(int id);
     }
 }

Assets/FirebaseREST/Database/FirebaseEventSourceWebGL.cs

@@ -30,7 +30,11 @@ public FirebaseEventSourceWebGL(string url, bool withCredentials, Action<Firebas
 
             public void Close()
             {
-                CloseEventSource(this.Id, EventSourceClosedCallback);
+                CloseEventSource(_id);
+                if (esWebGLMap.ContainsKey(_id))
+                {
+                    esWebGLMap.Remove(_id);
+                }
             }
         }
     }

Assets/Plugins/FirebaseREST/FirebaseEventSource.jslib

@@ -109,20 +109,13 @@
 		return es.Set(event);
 	},
 
-	CloseEventSource: function(id,onSuccess)
+	CloseEventSource: function(id)
 	{
 		console.log(id + ' ES_Close');
-
 		var event = es.Get(id);
-
-		try
-		{
-			event.close();
-		    es.Remove(id);
-            Runtime.dynCall('vi', onSuccess, [id]);
-		}
-		catch(e) {
-			es._callOnError(event.onError, id, e.name + ': ' + e.message);
+		if(event){
+			event.eventImpl.close();
+			es.Remove(id);
 		}
 	}
 };

README.md

@@ -1,9 +1,11 @@
-# Unity C# Firebase Realtime Database (REST API)
+# Unity Firebase Realtime Database REST API
 Write, Read, Remove and Streaming data using [Firebase's database REST API](https://firebase.google.com/docs/reference/rest/database)
 
 This is not firebase's official plugins library.
 
-Contributions to this project are welcome! 
+Tested on Android and WebGL platform. should work well on other platforms too since most of the implementation is only a simple http REST request.
+
+Contributions to this project are welcome!.
 
 ## Sample Usage