Skip to content

Commit 25cd5d7

Browse files
committed
Added clarity to sidebar docs
1 parent 70ee3bc commit 25cd5d7

File tree

2 files changed

+2
-1
lines changed

2 files changed

+2
-1
lines changed

components/popup/popup.directive.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -124,7 +124,7 @@ export class SuiPopupDirective {
124124
const factory = this._componentFactoryResolver.resolveComponentFactory(SuiPopup);
125125
this._popupComponentRef = this._viewContainerRef.createComponent(factory);
126126

127-
// Append the generated element to the body to avoid any positioning issues.
127+
// Move the generated element to the body to avoid any positioning issues.
128128
document.querySelector("body").appendChild(this._popupComponentRef.location.nativeElement);
129129

130130
this._popup.onClose.subscribe(() => {

demo/src/app/pages/sidebar/sidebar.page.html

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,7 @@ <h4 class="ui header">Direction</h4>
2222
<sidebar-example-direction></sidebar-example-direction>
2323
</div>
2424
</demo-example>
25+
<p>For a full page sidebar, just place all of your page content within a <code>sui-sidebar-container</code>.</p>
2526
<h2 id="api" class="ui dividing header">API</h2>
2627
<demo-api [api]="api"></demo-api>
2728
</demo-page-content>

0 commit comments

Comments
 (0)