Rename HttpClientRequest#setIdleTimeout -> idleTimeout

Author: vietj

src/main/asciidoc/http.adoc

@@ -1083,7 +1083,7 @@ no need to set the `Content-Length` of the request up-front.
 
 ==== Request timeouts
 
-You can set an idle timeout to prevent your application from unresponsive servers using {@link io.vertx.core.http.RequestOptions#setIdleTimeout(long)} or {@link io.vertx.core.http.HttpClientRequest#setIdleTimeout(long)}. When the request does not return any data within the timeout period an exception will fail the result and the request will be reset.
+You can set an idle timeout to prevent your application from unresponsive servers using {@link io.vertx.core.http.RequestOptions#setIdleTimeout(long)} or {@link io.vertx.core.http.HttpClientRequest#idleTimeout(long)}. When the request does not return any data within the timeout period an exception will fail the result and the request will be reset.
 
 [source,$lang]
 ----

src/main/java/io/vertx/core/http/HttpClientRequest.java

@@ -530,9 +530,9 @@ default Future<HttpClientResponse> send(ReadStream<Buffer> body) {
   void end(Handler<AsyncResult<Void>> handler);
 
   /**
-   * Like {@link #setIdleTimeout(long)} but with a confusing name (hence the deprecation).
+   * Like {@link #idleTimeout(long)} but with a confusing name (hence the deprecation).
    *
-   * @deprecated instead use {@link #setIdleTimeout(long)}
+   * @deprecated instead use {@link #idleTimeout(long)}
    */
   @Deprecated
   @Fluent
@@ -547,7 +547,7 @@ default Future<HttpClientResponse> send(ReadStream<Buffer> body) {
    * @return a reference to this, so the API can be used fluently
    */
   @Fluent
-  default HttpClientRequest setIdleTimeout(long timeout) {
+  default HttpClientRequest idleTimeout(long timeout) {
     return setTimeout(timeout);
   }
 

src/main/java/io/vertx/core/http/RequestOptions.java

@@ -406,7 +406,7 @@ public long getIdleTimeout() {
    * e.g. {@code Future<HttpClientResponse>} or {@code Future<Buffer>} response body.
    *
    * <p/>The timeout starts after a connection is obtained from the client, similar to calling
-   * {@link HttpClientRequest#setIdleTimeout(long)}.
+   * {@link HttpClientRequest#idleTimeout(long)}.
    *
    * @param timeout the amount of time in milliseconds.
    * @return a reference to this, so the API can be used fluently

src/main/java/io/vertx/core/http/impl/HttpClientImpl.java

@@ -387,7 +387,7 @@ public Endpoint<Lease<HttpClientConnection>> create(ContextInternal ctx, Runnabl
               req.setFollowRedirects(followRedirects);
             }
             if (idleTimeout > 0L) {
-              req.setIdleTimeout(idleTimeout);
+              req.idleTimeout(idleTimeout);
             }
             requestPromise.tryComplete(req);
           } else {

src/test/java/io/vertx/core/http/HttpClientTimeoutTest.java

@@ -199,7 +199,7 @@ public void start() throws Exception {
         for (int i = 0;i < n;i++) {
           AtomicBoolean responseReceived = new AtomicBoolean();
           client.request(requestOptions).onComplete(onSuccess(req -> {
-            req.setIdleTimeout(500);
+            req.idleTimeout(500);
             req.send(onSuccess(resp -> {
               try {
                 Thread.sleep(150);
@@ -225,7 +225,7 @@ public void testRequestIdleTimeoutCanceledWhenRequestEndsNormally() {
       client.request(requestOptions).onComplete(onSuccess(req -> {
         req
           .exceptionHandler(exception::set)
-          .setIdleTimeout(500)
+          .idleTimeout(500)
           .end();
         vertx.setTimer(1000, id -> {
           assertNull("Did not expect any exception", exception.get());
@@ -267,7 +267,7 @@ public void testHttpClientRequestIdleTimeoutResetsTheConnection() throws Excepti
       req.response(onFailure(err -> {
         complete();
       }));
-      req.setChunked(true).sendHead(onSuccess(version -> req.setIdleTimeout(500)));
+      req.setChunked(true).sendHead(onSuccess(version -> req.idleTimeout(500)));
       AtomicBoolean errored = new AtomicBoolean();
       req.exceptionHandler(err -> {
         if (errored.compareAndSet(false, true)) {
@@ -297,7 +297,7 @@ public void testResponseDataIdleTimeout() {
               complete();
             }
           });
-          resp.request().setIdleTimeout(500);
+          resp.request().idleTimeout(500);
           resp.handler(buff -> {
             received.appendBuffer(buff);
             // Force the internal timer to be rescheduled with the remaining amount of time