gates controlled on state 0

Author: purva-thakre

src/qrisp/interface/converter/cirq_converter.py

@@ -28,7 +28,6 @@
     "cx": CNOT,
     "cz": CZ,
     "swap": SWAP,
-    "2cx": CCNOT,
     "h": H,
     "x": X,
     "y": Y,
@@ -63,11 +62,6 @@ def convert_to_cirq(qrisp_circuit):
     qrisp_circ_num_qubits = qrisp_circuit.num_qubits()
     qrisp_circ_ops_data = qrisp_circuit.data
 
-    # create generic 'ncx' keys in qrisp_cirq_ops_dict for the possibility of multicontrolled cx gates
-    for n in range(3, qrisp_circ_num_qubits + 1):
-        # start at 3 because 2cx is a Toffoli gate which already exists in Cirq
-        qrisp_cirq_ops_dict[f"{n}cx"] = None
-
     # create an empty Cirq circuit
     cirq_circuit = Circuit()
     cirq_qubits = [LineQubit(i) for i in range(qrisp_circ_num_qubits)]
@@ -88,6 +82,8 @@ def convert_to_cirq(qrisp_circuit):
 
         if op_i not in qrisp_cirq_ops_dict:
             try:
+                # this code block also ends up transpiling a mcx gate
+                # qrisp allows for different types of control state but cirq does not
                 def transpile_predicate(op):
                     if op.name == op_i:
                         return True
@@ -111,7 +107,6 @@ def transpile_predicate(op):
             "cx",
             "cz",
             "swap",
-            "2cx",
             "h",
             "x",
             "y",
@@ -130,10 +125,6 @@ def transpile_predicate(op):
             "sx",
             "sx_dg",
         ]
-        # create generic 'ncx' keys in the cirq gates filter for the possibility of multicontrolled cx gates
-        for n in range(3, qrisp_circ_num_qubits + 1):
-            # start at 3 because 2cx is a Toffoli gate which already exists in Cirq
-            cirq_gates_filter.append(f"{n}cx")
 
         if (op_i not in cirq_gates_filter) and instr.op.definition:
             new_circ = instr.op.definition

tests/interface_tests/test_cirq_converter.py

@@ -124,6 +124,11 @@ def ghz(qv):
 
     reflection_compiled_qc = qv.qs.compile()
     reflection_cirq_qc = convert_to_cirq(reflection_compiled_qc)
+
+    expected_unitary = reflection_compiled_qc.get_unitary()
+    # multiple by -1 to account for the global phase factor
+    calculated_unitary = -1*unitary(reflection_cirq_qc)
+    np.testing.assert_array_almost_equal(expected_unitary, calculated_unitary)
 
 
 def test_transpiled_qc():