-
Notifications
You must be signed in to change notification settings - Fork 550
Description
Component
Kubernetes Maven Plugin
Task description
Description
I think this was probably introduced due to this refactor #2714
There is a method present in HelmMojo that is overriding a method from its superclass:
Lines 74 to 77 in 6ca26cd
| @Override | |
| protected HelmConfig.HelmType getDefaultHelmType() { | |
| return HelmConfig.HelmType.KUBERNETES; | |
| } |
However, if we look at the method in AbstractHelmMethod, it is identical to one in HelmMojo.
Lines 55 to 57 in 6ca26cd
| protected HelmConfig.HelmType getDefaultHelmType() { | |
| return HelmConfig.HelmType.KUBERNETES; | |
| } |
If HelmMojo's @Override method is not doing anything different, there is no point keeping it.
Expected Behavior
HelmMojo's redundant method identical to its super method is removed.
Acceptance Criteria
- redundant method is removed from HelmMojo
- Project compiles cleanly after running
mvn clean install
Before you start 🔴
👇 👇 👇 👇 👇 👇 👇 👇 👇 👇👇👇👇👇👇👇
Make sure you read the contributing guide first. Pay special attention to the ECA agreement section and the requirement to sign-off your commit.
How to manually test my changes
Kubernetes
If you don't have a real Kubernetes cluster available (most probably), you can use Minikube or Kind to test with a local cluster.
- Minikube get started guide
- Kind (Requires Docker) quick start
OpenShift
If you don't have a real OpenShift cluster available (most probably), you can use Red Hat's developer Sandbox for Red Hat OpenShift. The only requirement is to have a Red Hat account.
Once you have your Sandbox environment, you'll need to download the oc tool from the cluster console.
(Press the ? icon and from the context menu select Command line tools, you'll be redirected to https://$subdomain.openshiftapps.com/command-lines-tools where you'll be able to download the CLI for your platform)