Remove stack protector check from runtime_init (#3155)

earlephilhower · web-flow · commit ded8a8a8d9a8 · 2025-09-25T15:00:19.000-07:00
runtime_init will all the stack protector initializer from inside the function. Unfortunately that means that the sentinels for the runtime_init function will not be there and GCC will panic. Add no-stack-check attribute to the runtime_init function to avoid the check and re-enable stack smaeh protection. Fixes #3131
diff --git a/cores/rp2040/sdkoverride/newlib_interface.c b/cores/rp2040/sdkoverride/newlib_interface.c
@@ -170,7 +170,7 @@ void __weak __assert_func(const char *file, int line, const char *func, const ch
 }
 GCC_Pragma("GCC diagnostic pop")
 #endif
-void runtime_init(void) {
+__attribute__((no_stack_protector)) void runtime_init(void) {
 #ifndef NDEBUG
     if (__get_current_exception()) {
         // crap; started in exception handler

Original file line number	Diff line number	Diff line change
`@@ -170,7 +170,7 @@ void __weak __assert_func(const char file, int line, const char func, const ch`
`170`	`170`	`}`
`171`	`171`	`GCC_Pragma("GCC diagnostic pop")`
`172`	`172`	`#endif`
`173`		`-void runtime_init(void) {`
	`173`	`+__attribute__((no_stack_protector)) void runtime_init(void) {`
`174`	`174`	`#ifndef NDEBUG`
`175`	`175`	`if (__get_current_exception()) {`
`176`	`176`	`// crap; started in exception handler`