Added validation to launch_line_item, fixed up tests.

Author: RidleyLarsen

dynatademand/api.py

@@ -228,6 +228,13 @@ def get_project_detailed_report(self, project_id):
 
     def launch_line_item(self, project_id, line_item_id):
         # Starts traffic to a line item.
+        self.validator.validate_request(
+            'launch_line_item',
+            path_data={
+                'extProjectId': '{}'.format(project_id),
+                'extLineItemId': '{}'.format(line_item_id),
+            },
+        )
         response_data = self._api_post('/projects/{}/lineItems/{}/launch'.format(project_id, line_item_id), {})
         if response_data.get('status').get('message') != 'success':
             raise DemandAPIError(

dynatademand/schemas/request/path/launch_line_item.json

@@ -0,0 +1,17 @@
+{
+  "type": "object",
+  "properties": {
+    "extProjectId": {
+      "type": "string",
+      "required": true
+    },
+    "extLineItemId": {
+      "type": "string",
+      "required": true
+    }
+  },
+  "required": [
+    "extProjectId",
+    "extLineItemId"
+  ]
+}

dynatademand/validator.py

@@ -18,6 +18,7 @@
     'get_line_item': ['path', ],
     'get_line_items': ['path', 'query'],
     'get_line_item_detailed_report': ['path', ],
+    'launch_line_item': ['path', ],
     'update_line_item': ['path', 'body'],
 
     # Events

tests/test_line_items.py

@@ -54,10 +54,26 @@ def test_get_line_item_detailed_report(self):
     @responses.activate
     def test_launch_lineitem(self):
         # Tests closing a project.
-        responses.add(responses.POST, '{}/sample/v1/projects/24/lineItems/180/launch'.format(BASE_HOST), json={'status': {'message': 'success'}}, status=200)
-        responses.add(responses.POST, '{}/sample/v1/projects/24/lineItems/180/launch'.format(BASE_HOST), json={'status': {'message': 'error'}}, status=200)
+        responses.add(
+            responses.POST,
+            '{}/sample/v1/projects/24/lineItems/180/launch'.format(BASE_HOST),
+            json={'status': {'message': 'success'}},
+            status=200
+        )
+
+        # Response with error status
+        responses.add(
+            responses.POST,
+            '{}/sample/v1/projects/24/lineItems/180/launch'.format(BASE_HOST),
+            json={'status': {'message': 'error'}},
+            status=200
+        )
+
+        # Test successful response
         self.api.launch_line_item(24, 180)
         self.assertEqual(len(responses.calls), 1)
+
+        # Test error response
         with self.assertRaises(DemandAPIError):
             self.api.launch_line_item(24, 180)
         self.assertEqual(len(responses.calls), 2)