Ignore included record's relationships

Avoid the situation described here: danivek/json-api-serializer#10

Author: dynamiccast

lib/api/services/JsonApiService.js

@@ -129,6 +129,17 @@ module.exports = {
   serialize: function(modelName, data) {
 
     var returnedValue = Serializer.serialize(modelName, data);
+
+    /*
+     * To avoid the situation where many to many relationships are not described both ways
+     * let's remove all included record's relationships
+     * See https://github.com/danivek/json-api-serializer/issues/10 for more information
+     */
+    if (returnedValue.included) {
+      returnedValue.included.forEach((include) => {
+        delete include.relationships;
+      });
+    }
     delete returnedValue.jsonapi; // Let's ignore the version for now
 
     return returnedValue;

tests/dummy/test/integration/controllers/Relationships.test.js

@@ -124,11 +124,6 @@ describe("Has many through relationships", function() {
                     "id": houseId,
                     "attributes": {
                       "city": "Paris"
-                    },
-                    "relationships": {
-                      "pets": {
-                        "data": []
-                      }
                     }
                   }]
                 })