You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Copy file name to clipboardExpand all lines: CONTRIBUTING.md
+8-6Lines changed: 8 additions & 6 deletions
Display the source diff
Display the rich diff
Original file line number
Diff line number
Diff line change
@@ -17,7 +17,7 @@ We value and welcome all contributions including
17
17
Contributions can be made to the improve the base repository.
18
18
19
19
* The way to collaborate and work on the project is via GitHub: [github.com/dxc-technology/Sequences-as-Code](https://github.com/dxc-technology/Sequences-as-Code)
20
-
* For issues, bug fixes or adding new features, please create and submit a pull request
20
+
* For documentation updates, bug fixes or the addition of new features please create and submit a pull request
21
21
* For raising an issue or a defect, please open a [new github issue](https://github.com/dxc-technology/Sequences-as-Code/issues/new)
22
22
23
23
### Your Missions and Sequences
@@ -30,7 +30,7 @@ For instructions on how to
30
30
* Add your missions and sequences
31
31
* Perform common SaC tasks please
32
32
33
-
see the [documentation](./docs/README.md).
33
+
see the **SaC (Sequences as Code)**[documentation](./docs/README.md).
34
34
35
35
## Pull Requests
36
36
@@ -42,11 +42,13 @@ If your pull request is not accepted at first, please try again after addressing
42
42
43
43
### How to create and submit a pull request
44
44
45
-
***Fork** the repository
46
-
* Make **changes**on your local environment
45
+
***Fork** the [SaC (Sequences as Code)](https://dxc-technology.github.io/Sequences-as-Code/#/)repository
46
+
* Make **changes**in your local environment
47
47
***Test** your changes
48
-
* Submit **Pull Request** to the master repository including a brief description of the request. The **Pull Request** should include enough detail to enable the owner of the repository understand and process the request.
48
+
* Submit a **Pull Request** to the master repository including a brief description of the request. The **Pull Request** should include enough detail to enable the owner of the repository understand and process the request.
49
49
***@Mention** the team/team members in the comment section so the notification is sent. This alerts the team members of the need to review the code.
50
50
* Wait for the repo admins to review the changes and provide **feedback**.
51
51
52
-
As noted above please do not submit a pull request with your dedicated missions and sequences, these should be added to a dedicated instance of SaC. For details on how to stand up a dedicated instance see the [documentation](./docs/README.md).
52
+
As **noted** above please do not submit a pull request containing your dedicated missions and sequences, these should be added to a dedicated instance of SaC.
53
+
54
+
For details on how to stand up a dedicated instance of SaC refer to the **SaC (Sequences as Code)**[documentation](./docs/README.md).
Copy file name to clipboardExpand all lines: README.md
+3-3Lines changed: 3 additions & 3 deletions
Display the source diff
Display the rich diff
Original file line number
Diff line number
Diff line change
@@ -36,20 +36,20 @@ See a [history of the changes](CHANGELOG.md) to **SaC (Sequences as Code)**.
36
36
37
37
## Documentation
38
38
39
-
For instructions on how to perform common SaC tasks please see the [documentation](./docs/README.md).
39
+
For instructions on how to perform common **SaC (Sequences as Code)** tasks please see the [documentation](./docs/README.md).
40
40
41
41
## Contributing
42
42
43
43
We welcome all contributions please refer to [CONTRIBUTING.MD](/CONTRIBUTING.md) for details on how to contribute to this repository.
44
44
45
45
## Issues
46
46
47
-
If you experience some problems with the existing scenarios, please open an [issue](https://github.com/dxc-technology/Sequences-as-Code/issues/new/choose) and let us know about them.
47
+
If you experience problems with the application including the provided sequences, please open an [issue](https://github.com/dxc-technology/Sequences-as-Code/issues/new/choose) and let us know about them.
48
48
49
49
## License
50
50
51
51
This project is licensed under the Mozilla Public License Version 2.0 - see the [LICENSE](LICENSE) file for details.
52
52
53
53
## Create React App - Bootstrapped Readme.md
54
54
55
-
This project was bootstrapped with [Create React App](https://github.com/facebook/create-react-app). For your convenience the bootstrapped README.md is available at[CRA-README.md](./CRA-README.md).
55
+
This project was bootstrapped with [Create React App](https://github.com/facebook/create-react-app). For your convenience the bootstrapped README.md is available at[CRA-README.md](./CRA-README.md).
Copy file name to clipboardExpand all lines: docs/README.md
+13-13Lines changed: 13 additions & 13 deletions
Display the source diff
Display the rich diff
Original file line number
Diff line number
Diff line change
@@ -1,36 +1,36 @@
1
1
# README.md
2
2
3
-
The following instructions describe how to perform common tasks related to Sequences as Code.
3
+
The following instructions describe how to perform common tasks related to **SaC (Sequences as Code)**.
4
4
5
5
## Creating Sequences
6
6
7
-
Using SaC sequences are created as UML and grouped together as Missions.
7
+
When using SaC sequences are created as UML and grouped together as Missions.
8
8
9
-
Details on how to create the missions and sequences can be found in the SaC [Help](https://github.com/pages/dxc-technology/Sequences-as-Code/#/sachelp) mission and associated sequences.
9
+
Details on how to create missions and sequences can be found in the SaC [Help](https://github.com/pages/dxc-technology/Sequences-as-Code/#/sachelp) mission and it's associated sequences.
10
10
11
11
### Creating Sequences - Automatically
12
12
13
-
The option to convert the UML files to SVG is offered on every code commit from the continuous integration GitHub Action.
13
+
The option to convert the UML files to SVG is offered on every code commit from the code commit GitHub Action.
14
14
15
15
### Creating Sequences - Manually
16
16
17
17
Additionally the UML files can be converted to SVG manually in a local copy of a [Sequences as Code](https://github.com/dxc-technology/Sequences-as-Code) repository.
18
18
19
-
To generate the SVG files for a repository created from a release on the[Sequences as Code](https://github.com/dxc-technology/Sequences-as-Code), clone the repository then open a terminal session and run
19
+
To generate the SVG files for a repository created from a release of[Sequences as Code](https://github.com/dxc-technology/Sequences-as-Code), clone the repository then open a terminal session and run
20
20
21
21
```bash
22
22
./generatesvg.sh
23
23
```
24
24
25
-
The `./generatesvg.sh` script uses PlantUML a dockerized command line utility to convert UML files to SVG files. The script requires docker to be installed and running locally.
25
+
The `./generatesvg.sh` script uses PlantUML a dockerized command line utility to convert UML files to SVG files. The `./generatesvg.sh`script requires docker to be installed and running locally.
26
26
27
-
**Tip 1**`./generatesvg.sh` will generate SVG files for all the UML files it finds in the mission subfolders of the folder `src/sequences`. This may take some and should not be necessary for the SaC [Help](https://github.com/pages/dxc-technology/Sequences-as-Code/#/sachelp) mission. Prior to running `./generatesvg.sh` you can adjust the script to ensure it only finds and processes the UML files you need processed.
27
+
**Tip 1**`./generatesvg.sh` will generate SVG files for all the UML files it finds in the mission subfolders of the folder `src/sequences`. This may take some time and should not be necessary for the SaC [Help](https://github.com/pages/dxc-technology/Sequences-as-Code/#/sachelp) mission. Prior to running `./generatesvg.sh` you can adjust the script to ensure it only finds and processes the UML files you need processed.
28
28
29
-
**Tip 2** When running the `./generatesvg.sh` script you can ignore any WARNINGS reported. In the event of an ERROR unfortunately no details are provided by `think/plantuml`, so to view the specific error details you can use [PlantText](https://www.planttext.com/).
29
+
**Tip 2** When running the `./generatesvg.sh` script you can ignore any WARNINGS reported. In the event of an ERROR unfortunately no details are provided by `think/plantuml`. If you need to view specific error details you can use [PlantText](https://www.planttext.com/).
30
30
31
31
## Linking Sequences to Sequences
32
32
33
-
The create-react-app tool chain was used to create the single paged SaC application. The create-react-app scaffolder ensures each file inside of the build/static directory will have a unique hash appended to the filename. The unique hash is generated based on the contents of the file, this is to avoid browsers needing to re-download your assets if the file contents haven't changed. If the contents of a file changes in a subsequent build, the filename hash that is generated will be different.
33
+
The [create-react-app](https://create-react-app.dev/docs/getting-started/) tool chain was used to create the single paged SaC application. The create-react-app scaffolder ensures each file inside of the build/static directory will have a unique hash appended to the filename. The unique hash is generated based on the contents of the file, the hash is used to avoid browsers needing to re-download your assets if the file contents haven't changed. If the contents of a file changes in a subsequent build the filename hash that is generated will be different.
34
34
35
35
For images the filenames when built and deployed, both automatically and manually, are changed from
36
36
@@ -44,9 +44,9 @@ to
44
44
image.hash.svg
45
45
``
46
46
47
-
The fact that the sequence file names can change if the SVG files are regenerated prevents sequences from linking to other sequences.
47
+
The fact that the sequence file names change if the SVG files are regenerated prevents sequences from being linked to other sequences.
48
48
49
-
To allow sequences to link to other sequences a set of SaC "hashed" images are available in the `https://github.com/your_organisation/your_repository/images` folder. These images have consistent names as the SaC hash gives the image files the following names
49
+
To allow sequences be linked to other sequences a set of SaC "hashed" images are available in the `https://github.com/your_organisation/your_repository/images` folder. These images have consistent names as the SaC hash gives the image files the following names
50
50
51
51
``
52
52
sequence.image.svg
@@ -60,7 +60,7 @@ To do this:
60
60
61
61
- Open a terminal session and go to your cloned copy of the SaC repository
62
62
63
-
-Lint to verify react code is syntactically correct - `npm run lint`
63
+
-Run linting against the code to verify the react code is syntactically correct - `npm run lint`
64
64
65
65
- Run unit tests - `npm test`
66
66
@@ -76,7 +76,7 @@ When linting and testing is successful you can deploy the solution from your loc
76
76
77
77
-`npm run deploy`
78
78
79
-
as the solution has been configured to be hosted in a [GitHub pages site](https://github.com/gitname/react-gh-pages) after deployment it will be available at [http://github.com/pages/your_repository].
79
+
Because the solution has been configured to be hosted in a [GitHub pages site](https://github.com/gitname/react-gh-pages) after deployment it will be available at [http://github.com/pages/your_repository].
0 commit comments