Skip to content

Commit 6edb52f

Browse files
authored
minor documentation updates
* minor documentation updates * minor documentation updates * minor documentation updates
1 parent f7415e4 commit 6edb52f

File tree

5 files changed

+29
-24
lines changed

5 files changed

+29
-24
lines changed

.wordlist.txt

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,7 @@ Changelog
33
CHANGELOG
44
CRA
55
Dbased
6+
dev
67
Dockerfile
78
dockerized
89
dxc

CHANGELOG.md

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,8 +5,10 @@ All notable changes to the Sequences As Code (SaC) project will be documented in
55
The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
66
and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
77

8-
## [1.0.0] - 2020-07-30
8+
## [1.0.1] - 2020-08-05
9+
10+
- Minor documentation updates
911

10-
### Added
12+
## [1.0.0] - 2020-07-30
1113

1214
- Initial version

CONTRIBUTING.md

Lines changed: 8 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ We value and welcome all contributions including
1717
Contributions can be made to the improve the base repository.
1818

1919
* The way to collaborate and work on the project is via GitHub: [github.com/dxc-technology/Sequences-as-Code](https://github.com/dxc-technology/Sequences-as-Code)
20-
* For issues, bug fixes or adding new features, please create and submit a pull request
20+
* For documentation updates, bug fixes or the addition of new features please create and submit a pull request
2121
* For raising an issue or a defect, please open a [new github issue](https://github.com/dxc-technology/Sequences-as-Code/issues/new)
2222

2323
### Your Missions and Sequences
@@ -30,7 +30,7 @@ For instructions on how to
3030
* Add your missions and sequences
3131
* Perform common SaC tasks please
3232

33-
see the [documentation](./docs/README.md).
33+
see the **SaC (Sequences as Code)** [documentation](./docs/README.md).
3434

3535
## Pull Requests
3636

@@ -42,11 +42,13 @@ If your pull request is not accepted at first, please try again after addressing
4242

4343
### How to create and submit a pull request
4444

45-
* **Fork** the repository
46-
* Make **changes** on your local environment
45+
* **Fork** the [SaC (Sequences as Code)](https://dxc-technology.github.io/Sequences-as-Code/#/) repository
46+
* Make **changes** in your local environment
4747
* **Test** your changes
48-
* Submit **Pull Request** to the master repository including a brief description of the request. The **Pull Request** should include enough detail to enable the owner of the repository understand and process the request.
48+
* Submit a **Pull Request** to the master repository including a brief description of the request. The **Pull Request** should include enough detail to enable the owner of the repository understand and process the request.
4949
* **@Mention** the team/team members in the comment section so the notification is sent. This alerts the team members of the need to review the code.
5050
* Wait for the repo admins to review the changes and provide **feedback**.
5151

52-
As noted above please do not submit a pull request with your dedicated missions and sequences, these should be added to a dedicated instance of SaC. For details on how to stand up a dedicated instance see the [documentation](./docs/README.md).
52+
As **noted** above please do not submit a pull request containing your dedicated missions and sequences, these should be added to a dedicated instance of SaC.
53+
54+
For details on how to stand up a dedicated instance of SaC refer to the **SaC (Sequences as Code)** [documentation](./docs/README.md).

README.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -36,20 +36,20 @@ See a [history of the changes](CHANGELOG.md) to **SaC (Sequences as Code)**.
3636

3737
## Documentation
3838

39-
For instructions on how to perform common SaC tasks please see the [documentation](./docs/README.md).
39+
For instructions on how to perform common **SaC (Sequences as Code)** tasks please see the [documentation](./docs/README.md).
4040

4141
## Contributing
4242

4343
We welcome all contributions please refer to [CONTRIBUTING.MD](/CONTRIBUTING.md) for details on how to contribute to this repository.
4444

4545
## Issues
4646

47-
If you experience some problems with the existing scenarios, please open an [issue](https://github.com/dxc-technology/Sequences-as-Code/issues/new/choose) and let us know about them.
47+
If you experience problems with the application including the provided sequences, please open an [issue](https://github.com/dxc-technology/Sequences-as-Code/issues/new/choose) and let us know about them.
4848

4949
## License
5050

5151
This project is licensed under the Mozilla Public License Version 2.0 - see the [LICENSE](LICENSE) file for details.
5252

5353
## Create React App - Bootstrapped Readme.md
5454

55-
This project was bootstrapped with [Create React App](https://github.com/facebook/create-react-app). For your convenience the bootstrapped README.md is available at[CRA-README.md](./CRA-README.md).
55+
This project was bootstrapped with [Create React App](https://github.com/facebook/create-react-app). For your convenience the bootstrapped README.md is available at [CRA-README.md](./CRA-README.md).

docs/README.md

Lines changed: 13 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -1,36 +1,36 @@
11
# README.md
22

3-
The following instructions describe how to perform common tasks related to Sequences as Code.
3+
The following instructions describe how to perform common tasks related to **SaC (Sequences as Code)**.
44

55
## Creating Sequences
66

7-
Using SaC sequences are created as UML and grouped together as Missions.
7+
When using SaC sequences are created as UML and grouped together as Missions.
88

9-
Details on how to create the missions and sequences can be found in the SaC [Help](https://github.com/pages/dxc-technology/Sequences-as-Code/#/sachelp) mission and associated sequences.
9+
Details on how to create missions and sequences can be found in the SaC [Help](https://github.com/pages/dxc-technology/Sequences-as-Code/#/sachelp) mission and it's associated sequences.
1010

1111
### Creating Sequences - Automatically
1212

13-
The option to convert the UML files to SVG is offered on every code commit from the continuous integration GitHub Action.
13+
The option to convert the UML files to SVG is offered on every code commit from the code commit GitHub Action.
1414

1515
### Creating Sequences - Manually
1616

1717
Additionally the UML files can be converted to SVG manually in a local copy of a [Sequences as Code](https://github.com/dxc-technology/Sequences-as-Code) repository.
1818

19-
To generate the SVG files for a repository created from a release on the [Sequences as Code](https://github.com/dxc-technology/Sequences-as-Code), clone the repository then open a terminal session and run
19+
To generate the SVG files for a repository created from a release of [Sequences as Code](https://github.com/dxc-technology/Sequences-as-Code), clone the repository then open a terminal session and run
2020

2121
```bash
2222
./generatesvg.sh
2323
```
2424

25-
The `./generatesvg.sh` script uses PlantUML a dockerized command line utility to convert UML files to SVG files. The script requires docker to be installed and running locally.
25+
The `./generatesvg.sh` script uses PlantUML a dockerized command line utility to convert UML files to SVG files. The `./generatesvg.sh` script requires docker to be installed and running locally.
2626

27-
**Tip 1** `./generatesvg.sh` will generate SVG files for all the UML files it finds in the mission subfolders of the folder `src/sequences`. This may take some and should not be necessary for the SaC [Help](https://github.com/pages/dxc-technology/Sequences-as-Code/#/sachelp) mission. Prior to running `./generatesvg.sh` you can adjust the script to ensure it only finds and processes the UML files you need processed.
27+
**Tip 1** `./generatesvg.sh` will generate SVG files for all the UML files it finds in the mission subfolders of the folder `src/sequences`. This may take some time and should not be necessary for the SaC [Help](https://github.com/pages/dxc-technology/Sequences-as-Code/#/sachelp) mission. Prior to running `./generatesvg.sh` you can adjust the script to ensure it only finds and processes the UML files you need processed.
2828

29-
**Tip 2** When running the `./generatesvg.sh` script you can ignore any WARNINGS reported. In the event of an ERROR unfortunately no details are provided by `think/plantuml`, so to view the specific error details you can use [PlantText](https://www.planttext.com/).
29+
**Tip 2** When running the `./generatesvg.sh` script you can ignore any WARNINGS reported. In the event of an ERROR unfortunately no details are provided by `think/plantuml`. If you need to view specific error details you can use [PlantText](https://www.planttext.com/).
3030

3131
## Linking Sequences to Sequences
3232

33-
The create-react-app tool chain was used to create the single paged SaC application. The create-react-app scaffolder ensures each file inside of the build/static directory will have a unique hash appended to the filename. The unique hash is generated based on the contents of the file, this is to avoid browsers needing to re-download your assets if the file contents haven't changed. If the contents of a file changes in a subsequent build, the filename hash that is generated will be different.
33+
The [create-react-app](https://create-react-app.dev/docs/getting-started/) tool chain was used to create the single paged SaC application. The create-react-app scaffolder ensures each file inside of the build/static directory will have a unique hash appended to the filename. The unique hash is generated based on the contents of the file, the hash is used to avoid browsers needing to re-download your assets if the file contents haven't changed. If the contents of a file changes in a subsequent build the filename hash that is generated will be different.
3434

3535
For images the filenames when built and deployed, both automatically and manually, are changed from
3636

@@ -44,9 +44,9 @@ to
4444
image.hash.svg
4545
``
4646

47-
The fact that the sequence file names can change if the SVG files are regenerated prevents sequences from linking to other sequences.
47+
The fact that the sequence file names change if the SVG files are regenerated prevents sequences from being linked to other sequences.
4848

49-
To allow sequences to link to other sequences a set of SaC "hashed" images are available in the `https://github.com/your_organisation/your_repository/images` folder. These images have consistent names as the SaC hash gives the image files the following names
49+
To allow sequences be linked to other sequences a set of SaC "hashed" images are available in the `https://github.com/your_organisation/your_repository/images` folder. These images have consistent names as the SaC hash gives the image files the following names
5050

5151
``
5252
sequence.image.svg
@@ -60,7 +60,7 @@ To do this:
6060

6161
- Open a terminal session and go to your cloned copy of the SaC repository
6262

63-
- Lint to verify react code is syntactically correct - `npm run lint`
63+
- Run linting against the code to verify the react code is syntactically correct - `npm run lint`
6464

6565
- Run unit tests - `npm test`
6666

@@ -76,7 +76,7 @@ When linting and testing is successful you can deploy the solution from your loc
7676

7777
- `npm run deploy`
7878

79-
as the solution has been configured to be hosted in a [GitHub pages site](https://github.com/gitname/react-gh-pages) after deployment it will be available at [http://github.com/pages/your_repository].
79+
Because the solution has been configured to be hosted in a [GitHub pages site](https://github.com/gitname/react-gh-pages) after deployment it will be available at [http://github.com/pages/your_repository].
8080

8181
## Releases
8282

0 commit comments

Comments
 (0)