MACOSXPPC: Follow upstream dockerized-bb's update for SDL1.2, minus one OSXPPC PR

I avoided updating the SDL1.2 snapshots until now, because of the
libsdl-org/SDL-1.2#871 changes I don't trust
much (they just look untested).

Now I think it's time to sync our SDL1.2 snapshot again, but I've
chosen to revert this PR. It just looks like it reinstates code
that was disabled for years and years, and it looks like it only
affected OSX 10.3 and below, for which we don't care.

Maybe there's something good to be picked up in this PR, but for
now I'm not aware of a major issue regarding SDL1.2, and I've spent
enough time trying to understand what this old code does.

My findings were added to the top of this patch.

SDL1.2 remains built with /usr/bin/gcc-4.0 because of its reliance
on the Apple-only behavior of the -faltivec flag (otherwise, we either
loose Altivec acceleration code, or G3 compatibility).

Author: dwatteau

toolchains/macosx-ppc/packages/libsdl1.2/build.sh

@@ -1,9 +1,6 @@
 #! /bin/sh
 
-# note: avoiding later 7a877568f9250a1f6e2b77551878c06ce2f639bf on purpose
-# because that Darwin PPC change restored 10.3 and older "worse" APIs, and
-# more importantly that change has been merged without any test...
-SDL_VERSION=d95c1a4bbd644baba748d341b03141e5f0481ae6
+SDL_VERSION=0237f339e6bec39c56e1364787fabdb0245d478f
 
 PACKAGE_DIR=$(CDPATH= cd -- "$(dirname -- "$0")" && pwd)
 HELPERS_DIR=$PACKAGE_DIR/../../../common

toolchains/macosx-ppc/packages/libsdl1.2/patches/dont-reinstate-very-old-osx-apis.patch

@@ -0,0 +1,54 @@
+Someone recently added back some old OSX API calls to SDL1.2 on PPC:
+https://github.com/libsdl-org/SDL-1.2/pull/871
+
+Indeed, the original code checked for preprocessor values which don't
+exist on OSX PPC, and so it was never enabled.
+
+But it's been this way for years on OSX PPC, and nobody complained.
+Moreover, it looks like the older OSX API calls may have only been
+useful on pre-10.3 systems, which we don't support.
+
+Since the original PR writer doesn't appear to have tested these
+changes on OSX PPC, I prefer reverting to the previous SDL1.2
+behavior, which was effective in many official ScummVM build for
+OSX PPC without any reported issue.
+
+For more context: 
+
+http://forums.libsdl.org/viewtopic.php?p=29802
+https://github.com/libsdl-org/SDL-1.2/commit/7a877568f9250a1f6e2b77551878c06ce2f639bf
+https://github.com/libsdl-org/SDL-1.2/commit/ad8e59d08b892f00e856ca0b793f4dbc7481df65
+
+--- a/src/video/quartz/SDL_QuartzGL.m
++++ b/src/video/quartz/SDL_QuartzGL.m
+@@ -41,7 +41,7 @@
+ #define NSOpenGLPFASamples ((NSOpenGLPixelFormatAttribute) 56)
+ #endif
+ 
+-#ifdef __POWERPC__   /* we lost this in 10.7, which has no PPC support. */
++#if 0   /* we lost this in 10.6. */
+ @implementation NSOpenGLContext (CGLContextAccess)
+ - (CGLContextObj) cglContext;
+ {
+--- a/src/video/quartz/SDL_QuartzVideo.h
++++ b/src/video/quartz/SDL_QuartzVideo.h
+@@ -68,7 +68,7 @@
+ #include "../../events/SDL_events_c.h"
+ 
+ 
+-#ifdef __POWERPC__
++#if 0
+ /* 
+     This is a workaround to directly access NSOpenGLContext's CGL context
+     We need this to check for errors NSOpenGLContext doesn't support
+--- a/src/video/quartz/SDL_QuartzVideo.m
++++ b/src/video/quartz/SDL_QuartzVideo.m
+@@ -586,7 +586,7 @@
+                 QZ_TearDownOpenGL (this);
+             }
+ 
+-            #ifdef __ppc__  /* we only use this for pre-10.3 compatibility. */
++            #if 0  /* we only use this for pre-10.3 compatibility. */
+             CGLSetFullScreen (NULL);
+             #endif
+         }