Skip to content

Commit 7976f1a

Browse files
authored
Update broken links in CONTRIBUTING.md (#641)
Fixes #632
2 parents 413d703 + 559d633 commit 7976f1a

File tree

1 file changed

+5
-5
lines changed

1 file changed

+5
-5
lines changed

CONTRIBUTING.md

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -20,9 +20,9 @@ GEN=ninja make debug
2020
```
2121

2222
Related logics:
23-
* header file: https://github.com/duckdb/duckdb/blob/master/src/include/duckdb.h
24-
* impl file: https://github.com/duckdb/duckdb/blob/master/src/main/duckdb-c.cpp
25-
* test file: https://github.com/duckdb/duckdb/blob/master/test/api/capi/test_capi.cpp
23+
* header file: https://github.com/duckdb/duckdb/blob/main/src/include/duckdb.h
24+
* impl file: https://github.com/duckdb/duckdb/blob/main/src/main/capi/duckdb-c.cpp
25+
* test file: https://github.com/duckdb/duckdb/blob/main/test/api/capi/test_capi.cpp
2626
* You can refer to one of my previous PR: https://github.com/duckdb/duckdb/pull/1923
2727

2828
After make the change, we can build the repo and use it in `duckdb-rs` by:
@@ -53,14 +53,14 @@ cd ~/github/duckdb-rs/crates/libduckdb-sys
5353
cargo test --features bundled
5454
```
5555

56-
Currently in [github actions](https://github.com/duckdb/duckdb-rs/actions), we always use the bundled file for testing. So if you change the header in duckdb-cpp repo, you need to make the PR merged and updated the [bundled-file](https://github.com/duckdb/duckdb-rs/tree/main/crates/libduckdb-sys/duckdb).
56+
Currently in [github actions](https://github.com/duckdb/duckdb-rs/actions), we always use the bundled file for testing. So if you change the header in duckdb-cpp repo, you need to make the PR merged and updated the [`duckdb-sources` submodule](https://github.com/duckdb/duckdb-rs/tree/main/crates/libduckdb-sys).
5757
You can generated the amalgamated file by:
5858

5959
```shell
6060
cd ~/github/duckdb
6161
mkdir -p build/amaldebug
6262
python scripts/amalgamation.py
63-
cp src/amalgamation/duckdb.cpp src/include/duckdb.h src/amalgamation/duckdb.hpp ../duckdb-rs/crates/libduckdb-sys/duckdb/
63+
cp src/amalgamation/duckdb.cpp src/include/duckdb.h src/amalgamation/duckdb.hpp ../duckdb-rs/crates/libduckdb-sys/duckdb-sources/
6464
```
6565

6666
### duckdb-rs

0 commit comments

Comments
 (0)