IConfig: make project non-optional

Now that we set that information in the `defaultConfig`, and are about
to make the project config itself required, there is no need for any
implicit magic anymore.

This change is best viewed with `--ignore-space-change`.

Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>

Author: dscho

lib/project-config.ts

@@ -66,7 +66,7 @@ export interface IConfig {
     repo: IRepoConfig;
     mailrepo: IMailRepoConfig;
     mail: IMailConfig;
-    project?: projectInfo | undefined; // project-options values
+    project: projectInfo; // project-options values
     app: IAppConfig;
     lint: ILintConfig;
     user: IUserConfig;

lib/project-options.ts

@@ -1,7 +1,6 @@
 import { revParse } from "./git.js";
-import { IConfig, projectInfo } from "./project-config.js";
+import { IConfig } from "./project-config.js";
 
-// For now, only the Git, Cygwin and BusyBox projects are supported
 export class ProjectOptions {
     public static async get(
         config: IConfig,
@@ -12,30 +11,18 @@ export class ProjectOptions {
         basedOn?: string,
         publishToRemote?: string,
     ): Promise<ProjectOptions> {
-        let to: string;
-        let midUrlPrefix = " Message-ID: ";
-
-        if (Object.prototype.hasOwnProperty.call(config, "project")) {
-            const project = config.project as projectInfo;
-            to = `--to=${project.to}`;
-            midUrlPrefix = project.urlPrefix;
-            cc.push(...project.cc);
-            // Hard-code a check for gitgitgadget/git whether this is a Git GUI PR
-            // and hence needs the Git GUI maintainer to be Cc:ed
-            if (
-                `${config.repo.owner}/${config.repo.name}` === "gitgitgadget/git" &&
-                (await revParse(`${baseCommit}:git-gui.sh`, workDir)) !== undefined
-            ) {
-        } else if ((await revParse(`${baseCommit}:winsup`, workDir)) !== undefined) {
-            // Cygwin
-            to = "--to=cygwin-patches@cygwin.com";
-            midUrlPrefix = "https://www.mail-archive.com/search?l=cygwin-patches@cygwin.com&q=";
-        } else if ((await revParse(`${baseCommit}:include/busybox.h`, workDir)) !== undefined) {
-            // BusyBox
-            to = "--to=busybox@busybox.net";
-            midUrlPrefix = "https://www.mail-archive.com/search?l=busybox@busybox.net&q=";
-        } else {
-            throw new Error("Unrecognized project");
+        const to = `--to=${config.project.to}`;
+        const midUrlPrefix = config.project.urlPrefix;
+        cc.push(...config.project.cc);
+
+        // Hard-code a check for gitgitgadget/git whether this is a Git GUI PR
+        // and hence needs the Git GUI maintainer to be Cc:ed
+        if (
+            `${config.repo.owner}/${config.repo.name}` === "gitgitgadget/git" &&
+            (await revParse(`${baseCommit}:git-gui.sh`, workDir)) !== undefined
+        ) {
+            // Git GUI
+            cc.push("Johannes Sixt <j6t@kdbg.org>");
         }
 
         return new ProjectOptions(branchName, basedOn, publishToRemote, to, cc, midUrlPrefix, workDir, baseCommit);

tests/test-lib.ts

@@ -11,7 +11,6 @@ export const testConfig = {
     ...defaultConfig,
     // We're running in the test suite!
     project: {
-        cc: [],
         ...defaultConfig.project,
         to: "reviewer@example.com",
         urlPrefix: "https://dummy.com/?mid=",