forked from CoplayDev/unity-mcp
-
Notifications
You must be signed in to change notification settings - Fork 0
Fix/auto port fallback #101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from 2 commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
cd8256f
Fix macOS port conflict: Disable SO_REUSEADDR and improve UI port dis…
dsarno 5c83dec
Fix macOS port conflict: Disable SO_REUSEADDR and improve UI port dis…
dsarno b693edc
Address CodeRabbit feedback: UX improvements and code quality fixes
dsarno fed3042
Fix: Harden Python detection on Windows to handle App Execution Aliases
dsarno 11932f2
Refactor: Pre-resolve conflicts for McpConnectionSection and middleware
dsarno b7cb948
Merge remote-tracking branch 'origin/fix/auto-port-fallback' into fix…
dsarno dde79a9
Fix: Remove leftover merge conflict markers in StdioBridgeHost.cs
dsarno 9df1260
fix: clarify create_script tool description regarding base64 encoding
dsarno 222ea10
fix: improve python detection on macOS by checking specific Homebrew …
dsarno 7bcc217
Fix duplicate SetEnabled call and improve macOS Python detection
dsarno 0de71a3
Fix port display not reverting to saved preference when session ends
dsarno File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
style: Resource leak:
TcpClientis created without using statement, butclient.ConnectAsync()returns aTaskthat's awaited synchronously with.Wait(50). If connection times out or succeeds, theTcpClientmay not be properly disposed before entering thecatchblock or returning.Prompt To Fix With AI