Skip to content

Commit 7cf2ec0

Browse files
committed
docs: [PIPE-29374]: add GitHub App signed commits support and documentation
1 parent 8097ac1 commit 7cf2ec0

File tree

1 file changed

+3
-6
lines changed

1 file changed

+3
-6
lines changed

scm/driver/github/content.go

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -39,8 +39,7 @@ func (s *contentService) Create(ctx context.Context, repo, path string, params *
3939
Content: params.Data,
4040
}
4141

42-
// Only set author/committer if signature has non-empty name and email
43-
// For GitHub App signed commits, omit these fields entirely
42+
// Omit author/committer fields for GitHub App signed commits (empty signature)
4443
if params.Signature.Name != "" && params.Signature.Email != "" {
4544
in.Committer = &commitAuthor{
4645
Name: params.Signature.Name,
@@ -66,8 +65,7 @@ func (s *contentService) Update(ctx context.Context, repo, path string, params *
6665
Sha: params.BlobID,
6766
}
6867

69-
// Only set author/committer if signature has non-empty name and email
70-
// For GitHub App signed commits, omit these fields entirely
68+
// Omit author/committer fields for GitHub App signed commits (empty signature)
7169
if params.Signature.Name != "" && params.Signature.Email != "" {
7270
in.Committer = &commitAuthor{
7371
Name: params.Signature.Name,
@@ -91,8 +89,7 @@ func (s *contentService) Delete(ctx context.Context, repo, path string, params *
9189
Sha: params.BlobID,
9290
}
9391

94-
// Only set author/committer if signature has non-empty name and email
95-
// For GitHub App signed commits, omit these fields entirely
92+
// Omit author/committer fields for GitHub App signed commits (empty signature)
9693
if params.Signature.Name != "" && params.Signature.Email != "" {
9794
in.Committer = &commitAuthor{
9895
Name: params.Signature.Name,

0 commit comments

Comments
 (0)