Updated the setRequestHeader to be directly testable and updated the tests to match the behavior set in the test-headers.js file

Author: greenmanspirit

lib/XMLHttpRequest.js

@@ -111,7 +111,7 @@ exports.XMLHttpRequest = function() {
   this.responseXML = "";
   this.status = null;
   this.statusText = null;
-  
+
   // Whether cross-site Access-Control requests should be made using
   // credentials such as cookies or authorization headers
   this.withCredentials = false;
@@ -195,14 +195,15 @@ exports.XMLHttpRequest = function() {
     }
     if (!isAllowedHttpHeader(header)) {
       console.warn("Refused to set unsafe header \"" + header + "\"");
-      return;
+      return false;
     }
     if (sendFlag) {
       throw new Error("INVALID_STATE_ERR: send flag is true");
     }
     header = headersCase[header.toLowerCase()] || header;
     headersCase[header.toLowerCase()] = header;
     headers[header] = headers[header] ? headers[header] + ', ' + value : value;
+    return true;
   };
 
   /**

tests/test-exceptions.js

@@ -44,15 +44,14 @@ var forbiddenRequestHeaders = [
   "trailer",
   "transfer-encoding",
   "upgrade",
-  "user-agent",
   "via"
 ];
 
 for (var i in forbiddenRequestHeaders) {
   try {
-    xhr.setRequestHeader(forbiddenRequestHeaders[i], "Test");
-    console.log("ERROR: " + forbiddenRequestHeaders[i] + " should have thrown exception");
+    assert.equal(xhr.setRequestHeader(forbiddenRequestHeaders[i], "Test"), false);
   } catch(e) {
+    console.log("ERROR: Exception raised", e);
   }
 }