Clean up and standardize styles. Remove hanging commas, use double quotes

Author: driverdan

example/demo.js

@@ -6,7 +6,7 @@ var xhr = new XMLHttpRequest();
 xhr.onreadystatechange = function() {
 	sys.puts("State: " + this.readyState);
 
-	if (this.readyState == 4) {
+	if (this.readyState === 4) {
 		sys.puts("Complete.\nBody length: " + this.responseText.length);
 		sys.puts("Body:\n" + this.responseText);
 	}

lib/XMLHttpRequest.js

@@ -11,17 +11,19 @@
  * @license MIT
  */
 
-var Url = require("url")
-  , spawn = require("child_process").spawn
-  , fs = require('fs');
+var Url = require("url");
+var spawn = require("child_process").spawn;
+var fs = require("fs");
 
 exports.XMLHttpRequest = function() {
+  "use strict";
+
   /**
    * Private variables
    */
   var self = this;
-  var http = require('http');
-  var https = require('https');
+  var http = require("http");
+  var https = require("https");
 
   // Holds http.js objects
   var request;
@@ -183,11 +185,11 @@ exports.XMLHttpRequest = function() {
    * @param string value Header value
    */
   this.setRequestHeader = function(header, value) {
-    if (this.readyState != this.OPENED) {
+    if (this.readyState !== this.OPENED) {
       throw "INVALID_STATE_ERR: setRequestHeader can only be called when state is OPEN";
     }
     if (!isAllowedHttpHeader(header)) {
-      console.warn('Refused to set unsafe header "' + header + '"');
+      console.warn("Refused to set unsafe header \"" + header + "\"");
       return;
     }
     if (sendFlag) {
@@ -255,7 +257,7 @@ exports.XMLHttpRequest = function() {
    * @param string data Optional data to send as request body.
    */
   this.send = function(data) {
-    if (this.readyState != this.OPENED) {
+    if (this.readyState !== this.OPENED) {
       throw "INVALID_STATE_ERR: connection must be opened before send() is called";
     }
 
@@ -268,19 +270,19 @@ exports.XMLHttpRequest = function() {
     var host;
     // Determine the server
     switch (url.protocol) {
-      case 'https:':
+      case "https:":
         ssl = true;
         // SSL & non-SSL both need host, no break here.
-      case 'http:':
+      case "http:":
         host = url.hostname;
         break;
 
-      case 'file:':
+      case "file:":
         local = true;
         break;
 
       case undefined:
-      case '':
+      case "":
         host = "localhost";
         break;
 
@@ -295,7 +297,7 @@ exports.XMLHttpRequest = function() {
       }
 
       if (settings.async) {
-        fs.readFile(url.pathname, 'utf8', function(error, data) {
+        fs.readFile(url.pathname, "utf8", function(error, data) {
           if (error) {
             self.handleError(error);
           } else {
@@ -306,7 +308,7 @@ exports.XMLHttpRequest = function() {
         });
       } else {
         try {
-          this.responseText = fs.readFileSync(url.pathname, 'utf8');
+          this.responseText = fs.readFileSync(url.pathname, "utf8");
           this.status = 200;
           setState(self.DONE);
         } catch(e) {
@@ -321,21 +323,21 @@ exports.XMLHttpRequest = function() {
     // to use http://localhost:port/path
     var port = url.port || (ssl ? 443 : 80);
     // Add query string if one is used
-    var uri = url.pathname + (url.search ? url.search : '');
+    var uri = url.pathname + (url.search ? url.search : "");
 
     // Set the Host header or the server may reject the request
-    headers["Host"] = host;
+    headers.Host = host;
     if (!((ssl && port === 443) || port === 80)) {
-      headers["Host"] += ':' + url.port;
+      headers.Host += ":" + url.port;
     }
 
     // Set Basic Auth if necessary
     if (settings.user) {
-      if (typeof settings.password == "undefined") {
+      if (typeof settings.password === "undefined") {
         settings.password = "";
       }
       var authBuf = new Buffer(settings.user + ":" + settings.password);
-      headers["Authorization"] = "Basic " + authBuf.toString("base64");
+      headers.Authorization = "Basic " + authBuf.toString("base64");
     }
 
     // Set content length header
@@ -377,7 +379,7 @@ exports.XMLHttpRequest = function() {
       self.dispatchEvent("readystatechange");
 
       // Handler for the response
-      function responseHandler(resp) {
+      var responseHandler = function responseHandler(resp) {
         // Set response var to the response we got back
         // This is so it remains accessable outside this scope
         response = resp;
@@ -394,12 +396,12 @@ exports.XMLHttpRequest = function() {
             hostname: url.hostname,
             port: url.port,
             path: url.path,
-            method: response.statusCode === 303 ? 'GET' : settings.method,
+            method: response.statusCode === 303 ? "GET" : settings.method,
             headers: headers
           };
 
           // Issue the new request
-          request = doRequest(newOptions, responseHandler).on('error', errorHandler);
+          request = doRequest(newOptions, responseHandler).on("error", errorHandler);
           request.end();
           // @TODO Check if an XHR event needs to be fired here
           return;
@@ -410,7 +412,7 @@ exports.XMLHttpRequest = function() {
         setState(self.HEADERS_RECEIVED);
         self.status = response.statusCode;
 
-        response.on('data', function(chunk) {
+        response.on("data", function(chunk) {
           // Make sure there's some data
           if (chunk) {
             self.responseText += chunk;
@@ -421,26 +423,26 @@ exports.XMLHttpRequest = function() {
           }
         });
 
-        response.on('end', function() {
+        response.on("end", function() {
           if (sendFlag) {
-            // Discard the 'end' event if the connection has been aborted
+            // Discard the end event if the connection has been aborted
             setState(self.DONE);
             sendFlag = false;
           }
         });
 
-        response.on('error', function(error) {
+        response.on("error", function(error) {
           self.handleError(error);
         });
-      }
+      };
 
       // Error handler for the request
-      function errorHandler(error) {
+      var errorHandler = function errorHandler(error) {
         self.handleError(error);
-      }
+      };
 
       // Create the request
-      request = doRequest(options, responseHandler).on('error', errorHandler);
+      request = doRequest(options, responseHandler).on("error", errorHandler);
 
       // Node 0.4 and later won't accept empty data. Make sure it's needed.
       if (data) {
@@ -485,7 +487,7 @@ exports.XMLHttpRequest = function() {
       while(fs.existsSync(syncFile)) {
         // Wait while the sync file is empty
       }
-      self.responseText = fs.readFileSync(contentFile, 'utf8');
+      self.responseText = fs.readFileSync(contentFile, "utf8");
       // Kill the child process once the file has data
       syncProc.stdin.end();
       // Remove the temporary file

package.json

@@ -1,27 +1,27 @@
 {
-  "name": "xmlhttprequest"
-, "description": "XMLHttpRequest for Node"
-, "version": "1.6.0"
-, "author": {
-    "name": "Dan DeFelippi"
-  , "url": "http://driverdan.com"
-  }
-, "keywords": ["xhr", "ajax"]
-, "licenses": [{
-    "type": "MIT"
-  , "url": "http://creativecommons.org/licenses/MIT/"
-  }]
-, "repository": {
-    "type": "git"
-  , "url": "git://github.com/driverdan/node-XMLHttpRequest.git"
-  }
-, "bugs": "http://github.com/driverdan/node-XMLHttpRequest/issues"
-, "engines": {
+  "name": "xmlhttprequest",
+  "description": "XMLHttpRequest for Node",
+  "version": "1.6.0",
+  "author": {
+    "name": "Dan DeFelippi",
+    "url": "http://driverdan.com"
+  },
+  "keywords": ["xhr", "ajax"],
+  "licenses": [{
+    "type": "MIT",
+    "url": "http://creativecommons.org/licenses/MIT/"
+  }],
+  "repository": {
+    "type": "git",
+    "url": "git://github.com/driverdan/node-XMLHttpRequest.git"
+  },
+  "bugs": "http://github.com/driverdan/node-XMLHttpRequest/issues",
+  "engines": {
     "node": ">=0.4.0"
-  }
-, "directories": {
-    "lib": "./lib"
-  , "example": "./example"
-  }
-, "main": "./lib/XMLHttpRequest.js"
+  },
+  "directories": {
+    "lib": "./lib",
+    "example": "./example"
+  },
+  "main": "./lib/XMLHttpRequest.js"
 }