Skip to content

Commit 20de128

Browse files
committed
refactor: simplify exception handling and streamline header assignment in response
1 parent f7f3615 commit 20de128

File tree

3 files changed

+4
-5
lines changed

3 files changed

+4
-5
lines changed

src/Magicodes.ExporterAndImporter.AspNetCore/Extensions/MagicodesBase.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -62,7 +62,7 @@ public async Task<bool> HandleSuccessfulReqeustAsync(HttpContext context, object
6262
}
6363
if (contentType != "")
6464
{
65-
context.Response.Headers.Add("Content-Disposition", $"attachment;filename={filename}");
65+
context.Response.Headers["Content-Disposition"] = $"attachment;filename={filename}";
6666
context.Response.ContentType = contentType;
6767
if (result != null)
6868
{

src/Magicodes.ExporterAndImporter.Excel.AspNetCore/XlsxFileResultBase.cs

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -35,9 +35,8 @@ protected virtual async Task DownloadExcelFileAsync(ActionContext context,
3535
downloadFileName += ".xlsx";
3636
}
3737

38-
context.HttpContext.Response.Headers.Add("Content-Disposition", new[] {
39-
"attachment; filename=" +HttpUtility.UrlEncode(downloadFileName)
40-
});
38+
context.HttpContext.Response.Headers["Content-Disposition"] =
39+
"attachment; filename=" + HttpUtility.UrlEncode(downloadFileName);
4140
await stream.CopyToAsync(context.HttpContext.Response.Body);
4241
}
4342
}

src/Magicodes.ExporterAndImporter.Excel/Utility/TemplateExport/TemplateExportHelper.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -740,7 +740,7 @@ private bool RenderCellPipeline(Interpreter target, ExcelWorksheet sheet, ref st
740740
excelImage.SetSize(width, height);
741741
}
742742
}
743-
catch (Exception ex)
743+
catch
744744
{
745745
cell.Value = alt;
746746
}

0 commit comments

Comments
 (0)