Add logging for missing optional components and restore isOptional property

Co-authored-by: JoeRobich <611219+JoeRobich@users.noreply.github.com>

Author: Copilot

src/lsptoolshost/extensions/builtInComponents.ts

@@ -46,14 +46,21 @@ export const componentInfo: { [key: string]: ComponentInfo } = {
     },
 };
 
-export function getComponentPaths(componentName: string, options: LanguageServerOptions | undefined): string[] {
+export function getComponentPaths(
+    componentName: string,
+    options: LanguageServerOptions | undefined,
+    channel?: { warn: (message: string) => void }
+): string[] {
     const component = componentInfo[componentName];
     const baseFolder = getComponentFolderPath(component, options);
     const paths = component.componentDllPaths.map((dllPath) => path.join(baseFolder, dllPath));
     for (const dllPath of paths) {
         if (!fs.existsSync(dllPath)) {
             if (component.isOptional) {
-                // Component is optional and doesn't exist - return empty array
+                // Component is optional and doesn't exist - log warning and return empty array
+                if (channel) {
+                    channel.warn(`Optional component '${componentName}' could not be found at '${dllPath}'.`);
+                }
                 return [];
             }
             throw new Error(`Component DLL not found: ${dllPath}`);

src/lsptoolshost/server/roslynLanguageServer.ts

@@ -651,7 +651,7 @@ export class RoslynLanguageServer {
                 : razorOptions.razorServerPath;
 
         let razorComponentPath = '';
-        getComponentPaths('razorExtension', languageServerOptions).forEach((extPath) => {
+        getComponentPaths('razorExtension', languageServerOptions, channel).forEach((extPath) => {
             additionalExtensionPaths.push(extPath);
             razorComponentPath = path.dirname(extPath);
         });
@@ -695,10 +695,10 @@ export class RoslynLanguageServer {
             // Set command enablement as soon as we know devkit is available.
             await vscode.commands.executeCommand('setContext', 'dotnet.server.activationContext', 'RoslynDevKit');
 
-            const csharpDevKitArgs = this.getCSharpDevKitExportArgs(additionalExtensionPaths);
+            const csharpDevKitArgs = this.getCSharpDevKitExportArgs(additionalExtensionPaths, channel);
             args = args.concat(csharpDevKitArgs);
 
-            await this.setupDevKitEnvironment(dotnetInfo.env, csharpDevkitExtension, additionalExtensionPaths);
+            await this.setupDevKitEnvironment(dotnetInfo.env, csharpDevkitExtension, additionalExtensionPaths, channel);
         } else {
             // C# Dev Kit is not installed - continue C#-only activation.
             channel.info('Activating C# standalone...');
@@ -1012,10 +1012,13 @@ export class RoslynLanguageServer {
         );
     }
 
-    private static getCSharpDevKitExportArgs(additionalExtensionPaths: string[]): string[] {
+    private static getCSharpDevKitExportArgs(
+        additionalExtensionPaths: string[],
+        channel: vscode.LogOutputChannel
+    ): string[] {
         const args: string[] = [];
 
-        const devKitDepsPath = getComponentPaths('roslynDevKit', languageServerOptions);
+        const devKitDepsPath = getComponentPaths('roslynDevKit', languageServerOptions, channel);
         if (devKitDepsPath.length > 1) {
             throw new Error('Expected only one devkit deps path');
         }
@@ -1026,7 +1029,7 @@ export class RoslynLanguageServer {
 
         // Also include the Xaml Dev Kit extensions, if enabled.
         if (languageServerOptions.enableXamlTools) {
-            getComponentPaths('xamlTools', languageServerOptions).forEach((path) =>
+            getComponentPaths('xamlTools', languageServerOptions, channel).forEach((path) =>
                 additionalExtensionPaths.push(path)
             );
         }
@@ -1086,7 +1089,8 @@ export class RoslynLanguageServer {
     private static async setupDevKitEnvironment(
         env: NodeJS.ProcessEnv,
         csharpDevkitExtension: vscode.Extension<CSharpDevKitExports>,
-        additionalExtensionPaths: string[]
+        additionalExtensionPaths: string[],
+        channel: vscode.LogOutputChannel
     ): Promise<void> {
         const exports: CSharpDevKitExports = await csharpDevkitExtension.activate();
 
@@ -1096,7 +1100,7 @@ export class RoslynLanguageServer {
             await exports.setupTelemetryEnvironmentAsync(env);
         }
 
-        getComponentPaths('roslynCopilot', languageServerOptions).forEach((extPath) => {
+        getComponentPaths('roslynCopilot', languageServerOptions, channel).forEach((extPath) => {
             additionalExtensionPaths.push(extPath);
         });
     }

src/packageManager/IPackage.ts

@@ -13,4 +13,5 @@ export interface IPackage {
     platformId?: string;
     integrity?: string;
     isFramework?: boolean;
+    isOptional?: boolean;
 }

src/packageManager/absolutePathPackage.ts

@@ -20,7 +20,8 @@ export class AbsolutePathPackage implements IPackage {
         public fallbackUrl?: string,
         public platformId?: string,
         public integrity?: string,
-        public isFramework?: boolean
+        public isFramework?: boolean,
+        public isOptional?: boolean
     ) {}
 
     public static getAbsolutePathPackage(pkg: Package, extensionPath: string) {
@@ -36,7 +37,8 @@ export class AbsolutePathPackage implements IPackage {
             pkg.fallbackUrl,
             pkg.platformId,
             pkg.integrity,
-            pkg.isFramework
+            pkg.isFramework,
+            pkg.isOptional
         );
     }
 }

src/razor/src/extension.ts

@@ -104,7 +104,7 @@ export async function activate(
             await setupDevKitEnvironment(dotnetInfo.env, csharpDevkitExtension, logger);
 
             if (vscode.env.isTelemetryEnabled) {
-                const razorComponentPaths = getComponentPaths('razorDevKit', undefined);
+                const razorComponentPaths = getComponentPaths('razorDevKit', undefined, logger.outputChannel);
                 if (razorComponentPaths.length !== 1) {
                     logger.logError('Failed to find Razor DevKit telemetry extension path.', undefined);
                 } else {