Skip to content

Commit 09d6808

Browse files
Add Changelog for SignalR typescript client (#63392)
1 parent 1bce3f1 commit 09d6808

File tree

5 files changed

+96
-0
lines changed

5 files changed

+96
-0
lines changed

eng/scripts/CodeCheck.ps1

Lines changed: 19 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -208,6 +208,25 @@ try {
208208
LogError $file
209209
}
210210
}
211+
212+
# Check for relevant changes to SignalR typescript files
213+
$tsChanges = $changedFilesFromTarget | Where-Object { $_ -like "src/SignalR/clients/ts/*" -and $_ -ne "src/SignalR/clients/ts/CHANGELOG.md" }
214+
$changelogChanged = $changedFilesFromTarget -contains "src/SignalR/clients/ts/CHANGELOG.md"
215+
$signalrChangelogOverrideMarker = "[no changelog]"
216+
217+
# Only enforce changelog rule if there are relevant TS changes
218+
if ($tsChanges.Count -gt 0 -and -not $changelogChanged) {
219+
# Check if the override marker exists in recent commit messages
220+
$hasOverride = git log origin/$targetBranch..HEAD --pretty=%B | Select-String -Pattern $signalrChangelogOverrideMarker -Quiet
221+
222+
if (-not $hasOverride) {
223+
LogError "Changes were made to 'src/SignalR/clients/ts/', but no update to 'CHANGELOG.md' was found."
224+
LogError "Either update 'src/SignalR/clients/ts/CHANGELOG.md' or include '$signalrChangelogOverrideMarker' in your commit message."
225+
exit 1
226+
} else {
227+
Write-Host "SignalR Changelog update skipped due to override marker in commit message."
228+
}
229+
}
211230
}
212231
}
213232
finally {
Lines changed: 61 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,61 @@
1+
Change log contains changes for both @microsoft/signalr and @microsoft/signalr-protocol-msgpack.
2+
3+
## v10.0.0-rc.1
4+
5+
- Implemented fix for correctly reporting retries in the SignalR TS client. [#62812](https://github.com/dotnet/aspnetcore/pull/62812)
6+
- Send Keep-Alive Ping Immediately When Previous Ping Is Overdue [#63195](https://github.com/dotnet/aspnetcore/pull/63195)
7+
8+
## v10.0.0-preview.1.25120.3
9+
- Replaced deprecated `substr` usage with `substring` [#58732](https://github.com/dotnet/aspnetcore/pull/58732)
10+
- Bumped `ws` dependency to fix component vulnerability [#57536](https://github.com/dotnet/aspnetcore/pull/57536)
11+
- Bumped `webpack` from 5.93.0 to 5.94.0 [#57592](https://github.com/dotnet/aspnetcore/pull/57592)
12+
13+
## v9.0.0
14+
- Bumped `ws` dependency to address security vulnerability [#58458](https://github.com/dotnet/aspnetcore/pull/58458)
15+
16+
## v9.0.0-rc.2.24474.3
17+
- Added `Partitioned` flag to cookie for SignalR browser testing [#57997](https://github.com/dotnet/aspnetcore/pull/57997)
18+
19+
## v9.0.0-preview.7.24406.2
20+
- Reverted split Node dependency workaround due to issues [#56766](https://github.com/dotnet/aspnetcore/pull/56766)
21+
22+
## v9.0.0-preview.1.24081.5
23+
- Updated Karma config [#53247](https://github.com/dotnet/aspnetcore/pull/53247)
24+
- Node.js and npm infrastructure improvements [#53154](https://github.com/dotnet/aspnetcore/pull/53154)
25+
- Improved error handling in SignalR client: rejected promises in invocation messages [#52523](https://github.com/dotnet/aspnetcore/pull/52523)
26+
- Reordered SignalR message parameters for better readability [#51559](https://github.com/dotnet/aspnetcore/pull/51559)
27+
28+
## v8.0.12
29+
- Updated `serialize-javascript` dependency [#58466](https://github.com/dotnet/aspnetcore/pull/58466)
30+
31+
## v8.0.10
32+
- Upgraded `ws` from 7 to 7.5.10 [#57411](https://github.com/dotnet/aspnetcore/pull/57411)
33+
34+
## v8.0.7
35+
- Reverted incorrect handling of Node dependency splitting [#55229](https://github.com/dotnet/aspnetcore/pull/55229)
36+
- Fixed error handling for rejected promises in incoming Invocation messages [#55230](https://github.com/dotnet/aspnetcore/pull/55230)
37+
38+
## v8.0.2
39+
- Updated Karma config [#53411](https://github.com/dotnet/aspnetcore/pull/53411)
40+
41+
## v8.0.0-rc.2.23480.2
42+
- Introduced **Stateful Reconnect** support in SignalR [#49940](https://github.com/dotnet/aspnetcore/pull/49940)
43+
- Renamed internal `UseAck` to `UseStatefulReconnect` [#50407](https://github.com/dotnet/aspnetcore/pull/50407)
44+
- Incremented HubProtocol version for Stateful Reconnect [#50442](https://github.com/dotnet/aspnetcore/pull/50442)
45+
46+
## v8.0.0-preview.7.23375.9
47+
- Removed `__non_webpack_require__` workaround, improved Node dependency handling [#48154](https://github.com/dotnet/aspnetcore/pull/48154)
48+
49+
## v8.0.0-preview.6.23329.11
50+
- SignalR client now sends `CloseMessage` to server [#48577](https://github.com/dotnet/aspnetcore/pull/48577)
51+
52+
## v8.0.0-preview.5.23302.2
53+
- Fixed cookie handling with Fetch API on Node 18+ [#48076](https://github.com/dotnet/aspnetcore/pull/48076)
54+
55+
## v8.0.0-preview.4.23260.4
56+
- Upgraded Webpack for SignalR builds [#47403](https://github.com/dotnet/aspnetcore/pull/47403)
57+
58+
## v8.0.0-preview.1.23112.2
59+
- Fixed `CompletionMessage` handling for `false`/`null` result values [#45169](https://github.com/dotnet/aspnetcore/pull/45169)
60+
- Enabled `ServerTimeout` and `KeepAliveInterval` options in `HubConnectionBuilder` [#46065](https://github.com/dotnet/aspnetcore/pull/46065)
61+
- Migrated links to `learn.microsoft.com` [#46206](https://github.com/dotnet/aspnetcore/pull/46206)

src/SignalR/clients/ts/README.md

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,12 @@
1+
## ASP.NET Core SignalR Typescript
2+
3+
Contains the client-side implementation of the SignalR protocol in TypeScript/JavaScript.
4+
5+
* `signalr/`: Contains the core functionality for connecting and interacting with a SignalR server. Shipped as `@microsoft/signalr` on npm.
6+
* `signalr-protocol-msgpack/`: Contains an extension to the core library to use [msgpack](https://msgpack.org/) for it's core serialization logic instead of JSON. Shipped as `@microsoft/signalr-protocol-msgpack` on npm.
7+
8+
## Changelog
9+
10+
The changelog is located at [`CHANGELOG.md`](CHANGELOG.md). It is manually updated when changes are made to either of the npm packages we ship.
11+
12+
The CI should fail if changes are made to the libraries without any CHANGELOG updates. If the change isn't relevant to the CHANGELOG, add `[no changelog]` to one of the commit messages in the PR.

src/SignalR/clients/ts/signalr-protocol-msgpack/README.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,7 @@
11
MsgPack support for SignalR for ASP.NET Core
22

3+
[Changelog](https://github.com/dotnet/aspnetcore/tree/main/src/SignalR/clients/ts/CHANGELOG.md)
4+
35
## Installation
46

57
```bash

src/SignalR/clients/ts/signalr/README.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,7 @@
11
JavaScript and TypeScript clients for SignalR for ASP.NET Core and Azure SignalR Service
22

3+
[Changelog](https://github.com/dotnet/aspnetcore/tree/main/src/SignalR/clients/ts/CHANGELOG.md)
4+
35
## Installation
46

57
```bash

0 commit comments

Comments
 (0)