Skip to content

Commit 669eca9

Browse files
committed
removed extra comment
1 parent 233c070 commit 669eca9

File tree

3 files changed

+12
-17
lines changed

3 files changed

+12
-17
lines changed

src/DocumentFormat.OpenXml.Framework/Packaging/OpenXmlPart.cs

Lines changed: 8 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -43,25 +43,24 @@ internal void Load(OpenXmlPackage? openXmlPackage, OpenXmlPart? parent, Uri uriT
4343

4444
SetPackage(openXmlPackage, parent);
4545

46-
// add the _uri to be reserved
4746
IPackagePart? part = null;
4847
try
4948
{
49+
// TODO: should we delay load?
5050
part = _openXmlPackage.Features.GetRequired<IPackageFeature>().Package.GetPart(uriTarget);
5151
}
5252
catch (InvalidOperationException ex)
5353
{
5454
var errorMessage = SR.Format(
5555
ExceptionMessages.SpecifiedPartNotFound,
56-
uriTarget.OriginalString, ex.StackTrace);
57-
throw new OpenXmlPackageException(errorMessage);
56+
uriTarget.OriginalString, ex.Message);
57+
throw new InvalidOperationException(errorMessage);
5858
}
5959
catch (Exception)
6060
{
6161
throw;
6262
}
6363

64-
// TODO: should we delay load?
6564
Features.Set<IPackagePartFeature>(new PackagePartFeature(part));
6665

6766
if (IsContentTypeFixed && !IsValidContentType(part))
@@ -75,19 +74,13 @@ internal void Load(OpenXmlPackage? openXmlPackage, OpenXmlPart? parent, Uri uriT
7574
throw new OpenXmlPackageException(errorMessage);
7675
}
7776

78-
if (part is null)
79-
{
80-
var errorMessage = SR.Format(
81-
ExceptionMessages.InvalidPartContentType,
82-
part.Uri.OriginalString,
83-
part.ContentType,
84-
ContentType);
85-
86-
throw new OpenXmlPackageException(errorMessage);
87-
}
88-
8977
// add the _uri to be reserved
9078
Features.GetRequired<IPartUriFeature>().ReserveUri(ContentType, Uri);
79+
80+
81+
82+
83+
9184
}
9285

9386
internal void CreateInternal(OpenXmlPackage? openXmlPackage, OpenXmlPart? parent, string contentType, string? targetExt)

src/DocumentFormat.OpenXml.Framework/Resources/ExceptionMessages.Designer.cs

Lines changed: 2 additions & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

src/DocumentFormat.OpenXml.Framework/Resources/ExceptionMessages.resx

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -419,6 +419,7 @@
419419
</data>
420420
<data name="SpecifiedPartNotFound" xml:space="preserve">
421421
<value> Part: {0} doesn't exist in the package.
422-
{1}</value>
422+
423+
Original Message:{1}</value>
423424
</data>
424425
</root>

0 commit comments

Comments
 (0)