Skip to content

Commit 40571c1

Browse files
committed
Exclude symbols from signing and artifacts
The symbols are too large to push to myget so we are disabling them. There is currently no option to exclude symbol package generation, so we will manually do it in the sign script. This is fixed in preview4 of the tooling and should simplify the sign script.
1 parent e8668a4 commit 40571c1

File tree

2 files changed

+16
-20
lines changed

2 files changed

+16
-20
lines changed

appveyor.yml

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -21,10 +21,6 @@ after_build:
2121
test_script:
2222
- cmd: dotnet test -c Release .\DocumentFormat.OpenXml.Tests
2323

24-
artifacts:
25-
- path: '*.nupkg'
26-
name: NuGetArtifacts
27-
2824
deploy:
2925
provider: NuGet
3026
server: https://dotnet.myget.org/F/open-xml-sdk/api/v2/package

build/SignPackage.ps1

Lines changed: 16 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -1,24 +1,24 @@
11
$currentDirectory = split-path $MyInvocation.MyCommand.Definition
22

3-
# See if we have the ClientSecret available
4-
if([string]::IsNullOrEmpty($env:SignClientSecret)){
5-
Write-Host "Client Secret not found, not signing packages"
6-
return;
7-
}
8-
93
# Setup Variables we need to pass into the sign client tool
10-
114
$appSettings = "$currentDirectory\SignClientSettings.json"
125
$appPath = "$currentDirectory\SignClient\tools\SignClient.dll"
136

14-
$nupgks = ls $currentDirectory\..\*.nupkg | Select -ExpandProperty FullName
7+
$nupgks = ls $currentDirectory\..\*.nupkg `
8+
| Where Name -NotMatch symbols `
9+
| Select -ExpandProperty FullName
1510

1611
foreach ($nupkg in $nupgks){
17-
Write-Host "Submitting $nupkg for signing"
18-
19-
dotnet $appPath 'zip' -c $appSettings -i $nupkg -s $env:SignClientSecret -n 'DocumentFormat.OpenXML' -d 'DocumentFormat.OpenXML' -u 'https://github.com/OfficeDev/Open-XML-SDK'
20-
21-
Write-Host "Finished signing $nupkg"
22-
}
23-
24-
Write-Host "Sign-package complete"
12+
# See if we have the ClientSecret available
13+
if(![string]::IsNullOrEmpty($env:SignClientSecret)){
14+
Write-Host "Submitting $nupkg for signing"
15+
16+
dotnet $appPath 'zip' -c $appSettings -i $nupkg -s $env:SignClientSecret -n 'DocumentFormat.OpenXML' -d 'DocumentFormat.OpenXML' -u 'https://github.com/OfficeDev/Open-XML-SDK'
17+
18+
Write-Host "Finished signing $nupkg"
19+
} else {
20+
Write-Host "Client Secret not found, not signing package $nupkg"
21+
}
22+
23+
appveyor PushArtifact $nupkg
24+
}

0 commit comments

Comments
 (0)