🐞 Minor Bugfix: Modal

Summary: Fixed modal contents flashing in when presented (i.e init modal when modal contents has been mounted)

Author: dominicstop

example/ios/Podfile.lock

@@ -182,7 +182,7 @@ PODS:
     - React-cxxreact (= 0.62.2)
     - React-jsi (= 0.62.2)
   - React-jsinspector (0.62.2)
-  - react-native-ios-modal (0.1.6):
+  - react-native-ios-modal (0.1.7):
     - React
   - React-RCTActionSheet (0.62.2):
     - React-Core/RCTActionSheetHeaders (= 0.62.2)
@@ -350,7 +350,7 @@ SPEC CHECKSUMS:
   React-jsi: b6dc94a6a12ff98e8877287a0b7620d365201161
   React-jsiexecutor: 1540d1c01bb493ae3124ed83351b1b6a155db7da
   React-jsinspector: 512e560d0e985d0e8c479a54a4e5c147a9c83493
-  react-native-ios-modal: 292609c6ae163b2d28baa8af356ab1b43fe6b40a
+  react-native-ios-modal: 5dd74c818c53e1a6679eec89f6925b18c155dd87
   React-RCTActionSheet: f41ea8a811aac770e0cc6e0ad6b270c644ea8b7c
   React-RCTAnimation: 49ab98b1c1ff4445148b72a3d61554138565bad0
   React-RCTBlob: a332773f0ebc413a0ce85942a55b064471587a71

ios/src_library/React Native/RCTModalView/RCTModalView.swift

@@ -285,7 +285,9 @@ class RCTModalView: UIView {
     self.reactSubview = subview;
     self.touchHandler.attach(to: subview);
 
-    self.modalVC?.reactView = reactSubview;
+    // modal contents has been mounted, and is about to be presented so
+    // prepare for modal presentation and init the vc's
+    self.initControllers();
   };
 
   override func removeReactSubview(_ subview: UIView!) {
@@ -300,9 +302,11 @@ class RCTModalView: UIView {
     print("RCTModalView, removeReactSubview - for reactTag: \(self.reactTag ?? -1)");
     #endif
 
+    // modal contents has been unmounted so reset react subview
     self.reactSubview = nil;
     self.modalVC?.reactView = nil;
     self.touchHandler.detach(from: subview);
+    self.deinitControllers();
   };
 
 };
@@ -316,11 +320,6 @@ extension RCTModalView {
   public func presentModal(completion: completionResult = nil) {
     let hasWindow: Bool = (self.window != nil);
 
-    /// this view is going to be rendered, so we should init the controllers
-    if self.modalVC == nil || self.modalNVC == nil {
-      self.initControllers();
-    };
-    
     guard (hasWindow && !self.isPresented),
       let modalNVC = self.modalNVC,
       let (index, topMostPresentedVC) = self.getTopMostPresentedVC()