make csharp optional (Azure#34284)

Co-authored-by: Kyle Zhang <v-zhanh@microsoft.com>

Author: skywing918

eng/tools/typespec-validation/src/rules/sdk-tspconfig-validation.ts

@@ -111,6 +111,10 @@ class TspconfigEmitterOptionsSubRuleBase extends TspconfigSubRuleBase {
     this.emitterName = emitterName;
   }
 
+  public getEmitterName() {
+    return this.emitterName;
+  }
+
   protected tryFindOption(config: any): Record<string, any> | undefined {
     let option: Record<string, any> | undefined = config?.options?.[this.emitterName];
     for (const segment of this.keyToValidate.split(".")) {
@@ -503,7 +507,20 @@ export class SdkTspConfigValidationRule implements Rule {
       if (this.suppressedKeyPaths.has(subRule.getPathOfKeyToValidate())) continue;
       const result = await subRule.execute(folder!);
       if (!result.success) failedResults.push(result);
-      success &&= result.success;
+
+      let isSubRuleSuccess = result.success;
+
+      // TODO: remove when @azure-tools/typespec-csharp is ready for validating tspconfig
+      if (subRule instanceof TspconfigEmitterOptionsSubRuleBase) {
+        const emitterOptionSubRule = subRule as TspconfigEmitterOptionsSubRuleBase;
+        const emitterName = emitterOptionSubRule.getEmitterName();
+        if (emitterName === "@azure-tools/typespec-csharp" && isSubRuleSuccess === false) {
+          console.warn(`Validation on option "${emitterOptionSubRule.getPathOfKeyToValidate()}" in "${emitterName}" are failed. However, per ${emitterName}’s decision, we will treat it as passed.`);
+          isSubRuleSuccess = true;
+        }
+      }
+
+      success &&= isSubRuleSuccess;
     }
 
     const stdOutputFailedResults =

eng/tools/typespec-validation/test/sdk-tspconfig-validation.test.ts

@@ -70,6 +70,11 @@ export function createEmitterOptionExample(
   return content;
 }
 
+// TODO: remove when @azure-tools/typespec-csharp is ready for validating tspconfig
+function shouldBeTrueOnFailSubRuleValidation(emitterName: string) {
+  return emitterName === "@azure-tools/typespec-csharp" ? true : false;
+}
+
 function createParameterTestCases(
   folder: string,
   key: string,
@@ -130,15 +135,15 @@ function createEmitterOptionTestCases(
       key: key,
       value: invalidValue,
     }),
-    success: false,
+    success: shouldBeTrueOnFailSubRuleValidation(emitterName),
     subRules,
   });
 
   cases.push({
     description: `Validate ${language}'s option:${key} with undefined value`,
     folder,
     tspconfigContent: createEmitterOptionExample(emitterName),
-    success: allowUndefined ? true : false,
+    success: allowUndefined ? true : shouldBeTrueOnFailSubRuleValidation(emitterName),
     subRules,
   });
 
@@ -150,7 +155,7 @@ function createEmitterOptionTestCases(
         key: key.split(".").slice(0, -1).join("."),
         value: validValue,
       }),
-      success: false,
+      success: shouldBeTrueOnFailSubRuleValidation(emitterName),
       subRules,
     });
   }
@@ -460,7 +465,7 @@ const csharpAzNamespaceWithPackageDirTestCases: Case[] = [
       { key: "namespace", value: "namespace" },
       { key: "package-dir", value: "Azure.AAA" },
     ),
-    success: false,
+    success: shouldBeTrueOnFailSubRuleValidation("@azure-tools/typespec-csharp"),
     subRules: [new TspConfigCsharpAzNamespaceEqualStringSubRule()],
   },
 ];