Skip to content

Commit 52a48fd

Browse files
committed
Revert mod_remoteip support
Since using remoteip basically hides the fact that the wiki is running behind a reverse proxy, SSL autodetection no longer works (since we won't trust the X-FORWARDED-PROTO header in that case). Until we have a satisfactory solution to this issue, the change is reverted. This reverts commit b59c6af.
1 parent 90021a0 commit 52a48fd

File tree

4 files changed

+0
-12
lines changed

4 files changed

+0
-12
lines changed

Dockerfile

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -11,8 +11,6 @@ ARG DOKUWIKI_VERSION=stable
1111
ENV PHP_UPLOADLIMIT 128M
1212
ENV PHP_MEMORYLIMIT 256M
1313
ENV PHP_TIMEZONE UTC
14-
ENV FORWARDING_PROXY 172.16.0.0/12
15-
ENV FORWARDING_HEADER X-Forwarded-For
1614

1715
COPY root /
1816
RUN /bin/bash /build-setup.sh

README.md

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,6 @@ On first run, use DokuWiki's [installer](https://www.dokuwiki.org/installer) to
2626
## Features
2727

2828
* xsendfile configured and enabled
29-
* mod_remoteip enabled and configured to trust the standard Docker networking range
3029
* imagemagick installed and enabled
3130
* nice URLs via rewriting configured and enabled
3231
* farming support via the [farmer plugin](https://www.dokuwiki.org/plugin:farmer)
@@ -45,11 +44,6 @@ The container runs the standard production php.ini. Some options can be set via
4544

4645
Custom PHP configuration values can be set in a `php.ini` file in the storage volume.
4746

48-
The remoteip module is enabled and configured to use the `X-Forwarded-For` header and trust the standard Docker networking range. You can override both using the following environment variables:
49-
50-
* `FORWARDING_PROXY` - The trusted proxy IP range. Default `172.16.0.0/12`
51-
* `FORWARDING_HEADER` - The header to trust for the client IP. Default `X-Forwarded-For`
52-
5347
## Permissions
5448

5549
When the container is started without setting an explicit user id (as the compose file suggests), the image will start as

root/build-setup.sh

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,6 @@ a2enconf dokuwiki
1515
a2disconf security
1616
a2enmod rewrite
1717
a2enmod xsendfile
18-
a2enmod remoteip
1918

2019
# Download DokuWiki from the official website or from GitHub
2120
curl --fail -L "https://download.dokuwiki.org/src/dokuwiki/dokuwiki-${DOKUWIKI_VERSION}.tgz" -o dokuwiki.tgz || \

root/etc/apache2/conf-available/dokuwiki.conf

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,3 @@ ServerTokens Prod
1515
ServerSignature Off
1616
RedirectMatch 404 /\.git
1717
TraceEnable Off
18-
19-
RemoteIPInternalProxy ${FORWARDING_PROXY}
20-
RemoteIPHeader ${FORWARDING_HEADER}

0 commit comments

Comments
 (0)