Skip to content

Commit c752e67

Browse files
authored
Don't shadow Base functions (#4)
* add folds * Don't shadow base functions, rather extend them * Revert "add folds" This reverts commit 3f325e4.
1 parent 322d756 commit c752e67

File tree

2 files changed

+5
-5
lines changed

2 files changed

+5
-5
lines changed

environments/environment.jl

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -65,7 +65,7 @@ end
6565
gradients: flag for computing gradients of dynamics
6666
attitude_decompress: flag for pre- and post-concatenating Jacobians with attitude Jacobians
6767
"""
68-
function step(env::Environment, x, u;
68+
function Base.step(env::Environment, x, u;
6969
gradients=false,
7070
attitude_decompress=false)
7171

@@ -108,7 +108,7 @@ function step(env::Environment, x, u;
108108
return get_observation(env), -costs, done, info
109109
end
110110

111-
function step(env::Environment, u;
111+
function Base.step(env::Environment, u;
112112
gradients=false,
113113
attitude_decompress=false)
114114
step(env, env.state, u;
@@ -155,7 +155,7 @@ is_done(env::Environment, x) = false
155155
env: Environment
156156
x: state
157157
"""
158-
function reset(env::Environment{X};
158+
function Base.reset(env::Environment{X};
159159
x=nothing) where X
160160

161161
initialize!(env.mechanism, type2symbol(X))

src/Dojo.jl

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -243,11 +243,11 @@ export
243243
dynamics_jacobian_state,
244244
dynamics_jacobian_input,
245245
get_environment,
246-
step,
246+
#step,
247247
get_observation,
248248
cost,
249249
is_done,
250-
reset,
250+
#reset,
251251
render,
252252
seed,
253253
close,

0 commit comments

Comments
 (0)