add IDisposable implementation to ISession and ensure session disposal on connection failure

Author: doghappy

src/SocketIOClient/SocketIOClient.csproj

@@ -1,7 +1,8 @@
 <Project Sdk="Microsoft.NET.Sdk">
 
 	<PropertyGroup>
-		<TargetFrameworks>netstandard2;net462;net6.0</TargetFrameworks>
+		<!--<TargetFrameworks>netstandard2;net462;net6.0</TargetFrameworks>-->
+		<TargetFramework>netstandard2</TargetFramework>
 		<AssemblyName>SocketIOClient</AssemblyName>
 		<RootNamespace>SocketIOClient</RootNamespace>
 		<Authors>doghappy</Authors>

src/SocketIOClient/V2/Session/HttpSession.cs

@@ -80,27 +80,6 @@ private async Task OnNextTextMessage(string text)
             return;
         }
         await OnNextAsync(message);
-        // var newMessage= _engineIOAdapter.ProcessMessage(message);
-        // if (newMessage is null)
-        // {
-        //     return;
-        // }
-        // OnNextAsync(newMessage);
-        // var messages = _engineIOAdapter.HandleMessage(message);
-        // if (message.Type is MessageType.Ping)
-        // {
-        //     var lastPing = _dateTimeProvider.Now;
-        //     // TODO: using var cts = new CancellationTokenSource(Timeout);
-        //     _httpAdapter.SendAsync(new ProtocolMessage
-        //     {
-        //         Text = "3",
-        //     }, CancellationToken.None);
-        //     var pong = new PongMessage
-        //     {
-        //         Duration = _dateTimeProvider.Now - lastPing;
-        //     };
-        //     NotifyObservers(pong);
-        // }
     }
 
     private async Task OnNextBytesMessage(byte[] bytes)
@@ -160,4 +139,12 @@ public void Subscribe(IMyObserver<IMessage> observer)
         }
         _observers.Add(observer);
     }
+
+    public void Dispose()
+    {
+        if (_engineIOAdapter is IDisposable disposable)
+        {
+            disposable.Dispose();
+        }
+    }
 }

src/SocketIOClient/V2/Session/ISession.cs

@@ -1,3 +1,4 @@
+using System;
 using System.Threading;
 using System.Threading.Tasks;
 using SocketIOClient.Core;
@@ -6,7 +7,7 @@
 
 namespace SocketIOClient.V2.Session;
 
-public interface ISession : IMyObserver<ProtocolMessage>, IMyObservable<IMessage>, IMyObserver<IMessage>
+public interface ISession : IMyObserver<ProtocolMessage>, IMyObservable<IMessage>, IMyObserver<IMessage>, IDisposable
 {
     int PendingDeliveryCount { get; }
     Task SendAsync(object[] data, CancellationToken cancellationToken);

src/SocketIOClient/V2/SocketIO.cs

@@ -88,6 +88,7 @@ public async Task ConnectAsync(CancellationToken cancellationToken)
             }
             catch (Exception e)
             {
+                session.Dispose();
                 var ex = new ConnectionException($"Cannot connect to server '{ServerUri}'", e);
                 OnReconnectError?.Invoke(this, ex);
                 if (i == attempts - 1)

tests/SocketIOClient.UnitTests/V2/SocketIOTests.cs

@@ -165,6 +165,19 @@ await _io
             .ThrowAsync<OperationCanceledException>();
     }
 
+    [Fact]
+    public async Task ConnectAsync_FailedToConnect_SessionIsDisposed()
+    {
+        _session.ConnectAsync(Arg.Any<CancellationToken>()).ThrowsAsync(new Exception("Test"));
+
+        await _io
+            .Invoking(async x => await x.ConnectAsync())
+            .Should()
+            .ThrowAsync<ConnectionException>();
+
+        _session.Received().Dispose();
+    }
+
     [Fact]
     public async Task EmitAsync_AckEventAction_PacketIdIncrementBy1()
     {