refactor EngineIO3Adapter

Author: doghappy

src/SocketIOClient/V2/Session/EngineIOHttpAdapter/EngineIO3Adapter.cs

@@ -14,10 +14,6 @@ public IHttpRequest ToHttpRequest(ICollection<byte[]> bytes)
         {
             throw new ArgumentException("The array cannot be empty");
         }
-        if (bytes.Any(b => b.Length == 0))
-        {
-            throw new ArgumentException("The sub array cannot be empty");
-        }
         var req = new HttpRequest
         {
             Method = RequestMethod.Post,

tests/SocketIOClient.UnitTests/V2/Session/EngineIOHttpAdapter/EngineIO3AdapterTests.cs

@@ -24,20 +24,6 @@ public void ToHttpRequest_GivenAnEmptyArray_ThrowException()
             .WithMessage("The array cannot be empty");
     }
 
-    [Fact]
-    public void ToHttpRequest_GivenAnEmptySubBytes_ThrowException()
-    {
-        var bytes = new List<byte[]>
-        {
-            Array.Empty<byte>(),
-        };
-        _adapter
-            .Invoking(x => x.ToHttpRequest(bytes))
-            .Should()
-            .Throw<ArgumentException>()
-            .WithMessage("The sub array cannot be empty");
-    }
-
     private static readonly (ICollection<byte[]> bytes, IHttpRequest req) OneItem1Byte = new(new List<byte[]>
     {
         new byte[] { 1 },
@@ -102,8 +88,6 @@ public void ToHttpRequest_WhenCalled_AlwaysPass(ICollection<byte[]> bytes, IHttp
         req.Should().BeEquivalentTo(result);
     }
 
-    private static readonly (string raw, IEnumerable<string> textMessages) GetMessagesSinglePing = new("1:2", ["2"]);
-
     private static readonly (string raw, IEnumerable<string> textMessages) GetMessagesSingleHelloWorld = new(
         "12:hello world!",
         ["hello world!"]);
@@ -115,10 +99,6 @@ public void ToHttpRequest_WhenCalled_AlwaysPass(ICollection<byte[]> bytes, IHttp
     public static TheoryData<string, IEnumerable<string>> GetMessagesCases =>
         new()
         {
-            {
-                GetMessagesSinglePing.raw,
-                GetMessagesSinglePing.textMessages
-            },
             {
                 GetMessagesSingleHelloWorld.raw,
                 GetMessagesSingleHelloWorld.textMessages
@@ -133,6 +113,7 @@ public void ToHttpRequest_WhenCalled_AlwaysPass(ICollection<byte[]> bytes, IHttp
     [MemberData(nameof(GetMessagesCases))]
     public void GetMessages_WhenCalled_AlwaysPass(string raw, IEnumerable<string> textMessages)
     {
+        // Note: EngineIO3 bytes are handled by HttpSession directly, no need to test bytes here
         _adapter.GetMessages(raw)
             .Select(m => m.Text)
             .Should()