expose JsonSerializerOptions prop to let client change it

Author: doghappy

src/SocketIOClient/V2/Serializer/SystemTextJson/SystemJsonSerializer.cs

@@ -11,17 +11,17 @@ namespace SocketIOClient.V2.Serializer.SystemTextJson;
 
 public class SystemJsonSerializer : BaseJsonSerializer
 {
-    public SystemJsonSerializer(IDecapsulable decapsulator, JsonSerializerOptions options) : base(decapsulator)
+    public SystemJsonSerializer(IDecapsulable decapsulator) : base(decapsulator)
     {
-        _options = options;
+        JsonSerializerOptions = new JsonSerializerOptions();
     }
 
-    private readonly JsonSerializerOptions _options;
+    public JsonSerializerOptions JsonSerializerOptions { get; set; }
     public IEngineIOMessageAdapter EngineIOMessageAdapter { get; set; }
 
     private JsonSerializerOptions NewOptions(JsonConverter converter)
     {
-        var newOptions = new JsonSerializerOptions(_options);
+        var newOptions = new JsonSerializerOptions(JsonSerializerOptions);
         newOptions.Converters.Add(converter);
         return newOptions;
     }
@@ -93,23 +93,23 @@ private SystemJsonEventMessage NewEventMessage(string text)
     {
         var result = Decapsulator.DecapsulateEventMessage(text);
         var message = new SystemJsonEventMessage();
-        SetEventMessageProperties(result, message, _options);
+        SetEventMessageProperties(result, message, JsonSerializerOptions);
         return message;
     }
 
     private ISystemJsonAckMessage NewAckMessage(string text)
     {
         var result = Decapsulator.DecapsulateEventMessage(text);
         var message = new SystemJsonAckMessage();
-        SetAckMessageProperties(result, message, _options);
+        SetAckMessageProperties(result, message, JsonSerializerOptions);
         return message;
     }
 
     private SystemJsonBinaryEventMessage NewBinaryEventMessage(string text)
     {
         var result = Decapsulator.DecapsulateBinaryEventMessage(text);
         var message = new SystemJsonBinaryEventMessage();
-        SetEventMessageProperties(result, message, _options);
+        SetEventMessageProperties(result, message, JsonSerializerOptions);
         SetByteProperties(message, result.BytesCount);
         return message;
     }
@@ -124,7 +124,7 @@ private ISystemJsonAckMessage NewBinaryAckMessage(string text)
     {
         var result = Decapsulator.DecapsulateBinaryEventMessage(text);
         var message = new SystemJsonBinaryAckMessage();
-        SetAckMessageProperties(result, message, _options);
+        SetAckMessageProperties(result, message, JsonSerializerOptions);
         SetByteProperties(message, result.BytesCount);
         return message;
     }

tests/SocketIOClient.UnitTests/V2/Serializer/SystemTextJson/SystemJsonSerializerTests.cs

@@ -17,7 +17,7 @@ public class SystemJsonSerializerTests
 {
     public SystemJsonSerializerTests()
     {
-        _serializer = new SystemJsonSerializer(_realDecapsulator, new JsonSerializerOptions());
+        _serializer = new SystemJsonSerializer(_realDecapsulator);
     }
 
     private readonly SystemJsonSerializer _serializer;
@@ -34,7 +34,7 @@ public void Serialize_DataOnlyAndDataIsNull_ThrowArgumentNullException()
     [Fact]
     public void Serialize_DataOnlyAndDataIsEmpty_ThrowArgumentException()
     {
-        _serializer.Invoking(x => x.Serialize(Array.Empty<object>()))
+        _serializer.Invoking(x => x.Serialize([]))
             .Should()
             .Throw<ArgumentException>();
     }
@@ -200,11 +200,13 @@ public static TheoryData<object[], IEnumerable<ProtocolMessage>> SerializeDataOn
     [MemberData(nameof(SerializeDataOnlyCases))]
     public void Serialize_DataOnly_AlwaysPass(object[] data, IEnumerable<ProtocolMessage> expected)
     {
-        var options = new JsonSerializerOptions
+        var serializer = new SystemJsonSerializer(_realDecapsulator)
         {
-            Encoder = JavaScriptEncoder.UnsafeRelaxedJsonEscaping
+            JsonSerializerOptions = new JsonSerializerOptions
+            {
+                Encoder = JavaScriptEncoder.UnsafeRelaxedJsonEscaping
+            },
         };
-        var serializer = new SystemJsonSerializer(_realDecapsulator, options);
         serializer.Serialize(data).Should().BeEquivalentTo(expected);
     }
 
@@ -460,7 +462,7 @@ public void Deserialize_DecapsulationResultFalse_ReturnNull()
             {
                 Success = false,
             });
-        var serializer = new SystemJsonSerializer(decapsulator, new JsonSerializerOptions());
+        var serializer = new SystemJsonSerializer(decapsulator);
         const string text = "0{\"sid\":\"123\",\"upgrades\":[\"websocket\"],\"pingInterval\":10000,\"pingTimeout\":5000}";
 
         serializer.Deserialize(text).Should().BeNull();