fix _connCompletionSource state issue

Author: doghappy

src/SocketIOClient/V2/SocketIO.cs

@@ -59,6 +59,7 @@ private Uri ServerUri
     private readonly Dictionary<int, Action<IAckMessage>> _ackHandlers = new();
     private readonly Dictionary<int, Func<IAckMessage, Task>> _funcHandlers = new();
     private TaskCompletionSource<Exception> _connCompletionSource = new();
+    private TaskCompletionSource<Exception> _connCompletionSource;
     public SocketIOOptions Options { get; }
     public event EventHandler<Exception> OnReconnectError;
     public event EventHandler OnPing;
@@ -71,6 +72,7 @@ public async Task ConnectAsync()
 
     public async Task ConnectAsync(CancellationToken cancellationToken)
     {
+        _connCompletionSource = new TaskCompletionSource<Exception>();
         _ = ConnectCoreAsync(cancellationToken).ConfigureAwait(false);
         var task = Task.Run(async () => await _connCompletionSource.Task.ConfigureAwait(false), cancellationToken);
         var ex = await task.ConfigureAwait(false);

tests/SocketIOClient.UnitTests/V2/SocketIOTests.cs

@@ -294,4 +294,31 @@ public async Task DisconnectAsync_EverConnected_ClearStatefulData()
         _io.Id.Should().BeNull();
         _session.Received(1).Dispose();
     }
+
+    [Fact]
+    public async Task ConnectAsync_FirstFailedThenSuccess_ConnectedIsTrue()
+    {
+        _session.ConnectAsync(Arg.Any<CancellationToken>()).ThrowsAsync(new Exception("Test"));
+        await _io
+            .Invoking(async x => await x.ConnectAsync())
+            .Should()
+            .ThrowAsync<ConnectionException>();
+
+        _session.ConnectAsync(Arg.Any<CancellationToken>()).Returns(Task.CompletedTask);
+        await ConnectAsync();
+
+        _io.Connected.Should().BeTrue();
+    }
+
+    [Fact]
+    public async Task ConnectAsync_FirstSuccessThenFailed_ThrowConnectionException()
+    {
+        await ConnectAsync();
+
+        _session.ConnectAsync(Arg.Any<CancellationToken>()).ThrowsAsync(new Exception("Test"));
+        await _io
+            .Invoking(async x => await x.ConnectAsync())
+            .Should()
+            .ThrowAsync<ConnectionException>();
+    }
 }