#304 expose Namespace as a readonly property

Author: doghappy

src/SocketIOClient/SocketIO.cs

@@ -72,7 +72,7 @@ private Uri ServerUri
                     _serverUri = value;
                     if (value != null && value.AbsolutePath != "/")
                     {
-                        _namespace = value.AbsolutePath;
+                        Namespace = value.AbsolutePath;
                     }
                 }
             }
@@ -83,7 +83,7 @@ private Uri ServerUri
         /// </summary>
         public string Id { get; private set; }
 
-        string _namespace;
+        public string Namespace { get; private set; }
 
         /// <summary>
         /// Whether or not the socket is connected to the server.
@@ -211,7 +211,7 @@ private async Task InitTransportAsync()
                 Transport = new WebSocketTransport(transportOptions, ws);
             }
             _resources.Add(Transport);
-            Transport.Namespace = _namespace;
+            Transport.Namespace = Namespace;
             SetHeaders();
             Transport.SetProxy(Options.Proxy);
             Transport.OnReceived = OnMessageReceived;
@@ -550,7 +550,7 @@ public async Task DisconnectAsync()
             _connCts.TryDispose();
             var msg = new DisconnectedMessage
             {
-                Namespace = _namespace
+                Namespace = Namespace
             };
             try
             {
@@ -629,7 +629,7 @@ internal async Task ClientAckAsync(int packetId, CancellationToken cancellationT
                     msg = new ServerBinaryAckMessage
                     {
                         Id = packetId,
-                        Namespace = _namespace,
+                        Namespace = Namespace,
                         Json = result.Json
                     };
                     msg.OutgoingBytes = new List<byte[]>(result.Bytes);
@@ -638,7 +638,7 @@ internal async Task ClientAckAsync(int packetId, CancellationToken cancellationT
                 {
                     msg = new ServerAckMessage
                     {
-                        Namespace = _namespace,
+                        Namespace = Namespace,
                         Id = packetId,
                         Json = result.Json
                     };
@@ -648,7 +648,7 @@ internal async Task ClientAckAsync(int packetId, CancellationToken cancellationT
             {
                 msg = new ServerAckMessage
                 {
-                    Namespace = _namespace,
+                    Namespace = Namespace,
                     Id = packetId
                 };
             }
@@ -675,7 +675,7 @@ public async Task EmitAsync(string eventName, CancellationToken cancellationToke
                 {
                     var msg = new BinaryMessage
                     {
-                        Namespace = _namespace,
+                        Namespace = Namespace,
                         OutgoingBytes = new List<byte[]>(result.Bytes),
                         Event = eventName,
                         Json = result.Json
@@ -686,7 +686,7 @@ public async Task EmitAsync(string eventName, CancellationToken cancellationToke
                 {
                     var msg = new EventMessage
                     {
-                        Namespace = _namespace,
+                        Namespace = Namespace,
                         Event = eventName,
                         Json = result.Json
                     };
@@ -697,7 +697,7 @@ public async Task EmitAsync(string eventName, CancellationToken cancellationToke
             {
                 var msg = new EventMessage
                 {
-                    Namespace = _namespace,
+                    Namespace = Namespace,
                     Event = eventName
                 };
                 await Transport.SendAsync(msg, cancellationToken).ConfigureAwait(false);
@@ -727,7 +727,7 @@ public async Task EmitAsync(string eventName, CancellationToken cancellationToke
                     var msg = new ClientBinaryAckMessage
                     {
                         Event = eventName,
-                        Namespace = _namespace,
+                        Namespace = Namespace,
                         Json = result.Json,
                         Id = _packetId,
                         OutgoingBytes = new List<byte[]>(result.Bytes)
@@ -739,7 +739,7 @@ public async Task EmitAsync(string eventName, CancellationToken cancellationToke
                     var msg = new ClientAckMessage
                     {
                         Event = eventName,
-                        Namespace = _namespace,
+                        Namespace = Namespace,
                         Id = _packetId,
                         Json = result.Json
                     };
@@ -751,7 +751,7 @@ public async Task EmitAsync(string eventName, CancellationToken cancellationToke
                 var msg = new ClientAckMessage
                 {
                     Event = eventName,
-                    Namespace = _namespace,
+                    Namespace = Namespace,
                     Id = _packetId
                 };
                 await Transport.SendAsync(msg, cancellationToken).ConfigureAwait(false);

tests/SocketIOClient.UnitTest/SocketIOTest.cs

@@ -620,5 +620,16 @@ public async Task Should_be_able_to_cancel_reconnecting_after_disconnected()
         {
             await Should_be_able_to_cancel_reconnecting(async io => await io.DisconnectAsync());
         }
+        
+        [TestMethod]
+        [DataRow("http://localhost:11002", null)]
+        [DataRow("http://localhost:11002/", null)]
+        [DataRow("http://localhost:11002/namespace", "/namespace")]
+        [DataRow("http://localhost:11002/namespace/test", "/namespace/test")]
+        public void Should_set_namespace(string url, string ns)
+        {
+            using var io = new SocketIO(url);
+            io.Namespace.Should().Be(ns);
+        }
     }
-}
+}