Merge pull request #47 from smoench/lazy-commands

caciobanu · web-flow · commit 55f34b98a22b · 2020-01-20T21:48:04.000+02:00
use lazy command technique
diff --git a/src/AntiMattr/MongoDB/Migrations/Tools/Console/Command/ExecuteCommand.php b/src/AntiMattr/MongoDB/Migrations/Tools/Console/Command/ExecuteCommand.php
@@ -22,12 +22,11 @@
  */
 class ExecuteCommand extends AbstractCommand
 {
-    const NAME = 'mongodb:migrations:execute';
+    protected static $defaultName = 'mongodb:migrations:execute';
 
     protected function configure()
     {
         $this
-            ->setName($this->getName())
             ->setDescription('Execute a single migration version up or down manually.')
             ->addArgument('version', InputArgument::REQUIRED, 'The version to execute.', null)
             ->addOption('up', null, InputOption::VALUE_NONE, 'Execute the migration up.')
@@ -85,9 +84,4 @@ public function execute(InputInterface $input, OutputInterface $output)
 
         return 0;
     }
-
-    public function getName()
-    {
-        return self::NAME;
-    }
 }
diff --git a/src/AntiMattr/MongoDB/Migrations/Tools/Console/Command/GenerateCommand.php b/src/AntiMattr/MongoDB/Migrations/Tools/Console/Command/GenerateCommand.php
@@ -21,7 +21,7 @@
  */
 class GenerateCommand extends AbstractCommand
 {
-    const NAME = 'mongodb:migrations:generate';
+    protected static $defaultName = 'mongodb:migrations:generate';
 
     private static $_template =
             '<?php
@@ -61,7 +61,6 @@ public function down(Database $db)
     protected function configure()
     {
         $this
-                ->setName($this->getName())
                 ->setDescription('Generate a blank migration class.')
                 ->addOption('editor-cmd', null, InputOption::VALUE_OPTIONAL, 'Open file with this command upon creation.')
                 ->setHelp(<<<'EOT'
@@ -103,7 +102,7 @@ public function execute(InputInterface $input, OutputInterface $output)
      *
      * @return string $path
      *
-     * @throws InvalidArgumentException
+     * @throws \InvalidArgumentException
      */
     protected function generateMigration(Configuration $configuration, InputInterface $input, $version, $up = null, $down = null)
     {
@@ -178,12 +177,4 @@ protected function getVersionString()
     {
         return date('YmdHis');
     }
-
-    /**
-     * @return string
-     */
-    public function getName()
-    {
-        return self::NAME;
-    }
 }
diff --git a/src/AntiMattr/MongoDB/Migrations/Tools/Console/Command/MigrateCommand.php b/src/AntiMattr/MongoDB/Migrations/Tools/Console/Command/MigrateCommand.php
@@ -23,12 +23,11 @@
  */
 class MigrateCommand extends AbstractCommand
 {
-    const NAME = 'mongodb:migrations:migrate';
+    protected static $defaultName = 'mongodb:migrations:migrate';
 
     protected function configure()
     {
         $this
-            ->setName($this->getName())
             ->setDescription('Execute a migration to a specified version or the latest available version.')
             ->addArgument('version', InputArgument::OPTIONAL, 'The version to migrate to.', null)
             ->setHelp(<<<'EOT'
@@ -126,9 +125,4 @@ protected function createMigration(Configuration $configuration)
     {
         return new Migration($configuration);
     }
-
-    public function getName()
-    {
-        return self::NAME;
-    }
 }
diff --git a/src/AntiMattr/MongoDB/Migrations/Tools/Console/Command/StatusCommand.php b/src/AntiMattr/MongoDB/Migrations/Tools/Console/Command/StatusCommand.php
@@ -22,12 +22,11 @@
  */
 class StatusCommand extends AbstractCommand
 {
-    const NAME = 'mongodb:migrations:status';
+    protected static $defaultName = 'mongodb:migrations:status';
 
     protected function configure()
     {
         $this
-            ->setName($this->getName())
             ->setDescription('View the status of a set of migrations.')
             ->addOption(
                 'show-versions',
@@ -177,14 +176,4 @@ protected function writeInfoLine(OutputInterface $output, $name, $value)
             )
         );
     }
-
-    /**
-     * getName.
-     *
-     * @return string
-     */
-    public function getName()
-    {
-        return self::NAME;
-    }
 }
diff --git a/src/AntiMattr/MongoDB/Migrations/Tools/Console/Command/VersionCommand.php b/src/AntiMattr/MongoDB/Migrations/Tools/Console/Command/VersionCommand.php
@@ -24,12 +24,11 @@
  */
 class VersionCommand extends AbstractCommand
 {
-    const NAME = 'mongodb:migrations:version';
+    protected static $defaultName = 'mongodb:migrations:version';
 
     protected function configure()
     {
         $this
-            ->setName($this->getName())
             ->setDescription('Manually add and delete migration versions from the version table.')
             ->addArgument('version', InputArgument::REQUIRED, 'The version to add or delete.', null)
             ->addOption('add', null, InputOption::VALUE_NONE, 'Add the specified version.')
@@ -52,8 +51,8 @@ protected function configure()
      * @param \Symfony\Component\Console\Input\InputInterface
      * @param \Symfony\Component\Console\Output\OutputInterface
      *
-     * @throws AntiMattr\MongoDB\Migrations\Exception\UnknownVersionException Throws exception if migration version does not exist
-     * @throws InvalidArgumentException
+     * @throws UnknownVersionException Throws exception if migration version does not exist
+     * @throws \InvalidArgumentException
      */
     public function execute(InputInterface $input, OutputInterface $output)
     {
@@ -93,9 +92,4 @@ protected function createMigration(Configuration $configuration)
     {
         return new Migration($configuration);
     }
-
-    public function getName()
-    {
-        return self::NAME;
-    }
 }
diff --git a/tests/AntiMattr/Tests/MongoDB/Migrations/Tools/Console/Command/ExecuteCommandTest.php b/tests/AntiMattr/Tests/MongoDB/Migrations/Tools/Console/Command/ExecuteCommandTest.php
@@ -38,7 +38,7 @@ public function testExecuteDownWithoutInteraction()
         $input = new ArgvInput(
             [
                 'application-name',
-                ExecuteCommand::NAME,
+                ExecuteCommand::getDefaultName(),
                 $numVersion,
                 '--down',
             ]
@@ -89,7 +89,7 @@ public function testExecuteUpWithInteraction()
         $input = new ArgvInput(
             [
                 'application-name',
-                ExecuteCommand::NAME,
+                ExecuteCommand::getDefaultName(),
                 $numVersion,
             ]
         );
@@ -167,7 +167,7 @@ public function testExecuteReplayWithoutInteraction()
         $input = new ArgvInput(
             [
                 'application-name',
-                ExecuteCommand::NAME,
+                ExecuteCommand::getDefaultName(),
                 $numVersion,
                 '--up',
                 '--replay',
diff --git a/tests/AntiMattr/Tests/MongoDB/Migrations/Tools/Console/Command/GenerateCommandTest.php b/tests/AntiMattr/Tests/MongoDB/Migrations/Tools/Console/Command/GenerateCommandTest.php
@@ -43,7 +43,7 @@ public function testExecute()
 
         $input = new ArgvInput(
             [
-                GenerateCommand::NAME,
+                GenerateCommand::getDefaultName(),
             ]
         );
 
@@ -87,7 +87,7 @@ public function testExecuteWithInvalidMigrationDirectory()
 
         $input = new ArgvInput(
             [
-                GenerateCommand::NAME,
+                GenerateCommand::getDefaultName(),
             ]
         );
 
diff --git a/tests/AntiMattr/Tests/MongoDB/Migrations/Tools/Console/Command/MigrateCommandTest.php b/tests/AntiMattr/Tests/MongoDB/Migrations/Tools/Console/Command/MigrateCommandTest.php
@@ -37,7 +37,7 @@ public function testExecuteWithExectedUnavailableVersionAndInteraction()
         $input = new ArgvInput(
             [
                 'application-name',
-                MigrateCommand::NAME,
+                MigrateCommand::getDefaultName(),
                 $numVersion,
             ]
         );
@@ -103,7 +103,7 @@ public function testExecute()
         $numVersion = '000123456789';
         $input = new ArgvInput(
             [
-                MigrateCommand::NAME,
+                MigrateCommand::getDefaultName(),
                 $numVersion,
             ]
         );
@@ -217,6 +217,8 @@ public function testDefaultSecondInteractionWillCancelMigration()
 
 class MigrateCommandStub extends MigrateCommand
 {
+    protected static $defaultName = 'mongodb:migrations:migrate';
+
     protected $migration;
 
     public function setMigration(Migration $migration)
diff --git a/tests/AntiMattr/Tests/MongoDB/Migrations/Tools/Console/Command/StatusCommandTest.php b/tests/AntiMattr/Tests/MongoDB/Migrations/Tools/Console/Command/StatusCommandTest.php
@@ -53,7 +53,7 @@ public function testExecuteWithoutShowingVersions()
     {
         $input = new ArgvInput(
             [
-                StatusCommand::NAME,
+                StatusCommand::getDefaultName(),
             ]
         );
 
@@ -213,7 +213,7 @@ public function testExecuteWithShowingVersions()
     {
         $input = new ArgvInput(
             [
-                StatusCommand::NAME,
+                StatusCommand::getDefaultName(),
                 '--show-versions',
             ]
         );
diff --git a/tests/AntiMattr/Tests/MongoDB/Migrations/Tools/Console/Command/VersionCommandTest.php b/tests/AntiMattr/Tests/MongoDB/Migrations/Tools/Console/Command/VersionCommandTest.php
@@ -40,7 +40,7 @@ public function testInvalidArgumentException()
         $numVersion = '123456789012';
         $input = new ArgvInput(
             [
-                VersionCommand::NAME,
+                VersionCommand::getDefaultName(),
                 $numVersion,
             ]
         );
@@ -61,7 +61,7 @@ public function testUnknownVersionException()
         $numVersion = '123456789012';
         $input = new ArgvInput(
             [
-                VersionCommand::NAME,
+                VersionCommand::getDefaultName(),
                 $numVersion,
                 '--add',
             ]
@@ -89,7 +89,7 @@ public function testAddVersion()
         $numVersion = '123456789012';
         $input = new ArgvInput(
             [
-                VersionCommand::NAME,
+                VersionCommand::getDefaultName(),
                 $numVersion,
                 '--add',
             ]
@@ -137,7 +137,7 @@ public function testDownVersion()
         $numVersion = '123456789012';
         $input = new ArgvInput(
             [
-                VersionCommand::NAME,
+                VersionCommand::getDefaultName(),
                 $numVersion,
                 '--delete',
             ]
@@ -188,7 +188,7 @@ public function testDownOnNonMigratedVersionThrowsInvalidArgumentException()
         $numVersion = '123456789012';
         $input = new ArgvInput(
             [
-                VersionCommand::NAME,
+                VersionCommand::getDefaultName(),
                 $numVersion,
                 '--delete',
             ]
@@ -235,7 +235,7 @@ public function testUpOnMigratedVersionThrowsInvalidArgumentException()
         $numVersion = '123456789012';
         $input = new ArgvInput(
             [
-                VersionCommand::NAME,
+                VersionCommand::getDefaultName(),
                 $numVersion,
                 '--add',
             ]

Original file line number	Diff line number	Diff line change
`@@ -22,12 +22,11 @@`
`22`	`22`	`*/`
`23`	`23`	`class ExecuteCommand extends AbstractCommand`
`24`	`24`	`{`
`25`		`- const NAME = 'mongodb:migrations:execute';`
	`25`	`+ protected static $defaultName = 'mongodb:migrations:execute';`
`26`	`26`
`27`	`27`	`protected function configure()`
`28`	`28`	`{`
`29`	`29`	`$this`
`30`		`- ->setName($this->getName())`
`31`	`30`	`->setDescription('Execute a single migration version up or down manually.')`
`32`	`31`	`->addArgument('version', InputArgument::REQUIRED, 'The version to execute.', null)`
`33`	`32`	`->addOption('up', null, InputOption::VALUE_NONE, 'Execute the migration up.')`
`@@ -85,9 +84,4 @@ public function execute(InputInterface $input, OutputInterface $output)`
`85`	`84`
`86`	`85`	`return 0;`
`87`	`86`	`}`
`88`		`-`
`89`		`- public function getName()`
`90`		`- {`
`91`		`- return self::NAME;`
`92`		`- }`
`93`	`87`	`}`
Original file line number	Diff line number	Diff line change
`@@ -21,7 +21,7 @@`
`21`	`21`	`*/`
`22`	`22`	`class GenerateCommand extends AbstractCommand`
`23`	`23`	`{`
`24`		`- const NAME = 'mongodb:migrations:generate';`
	`24`	`+ protected static $defaultName = 'mongodb:migrations:generate';`
`25`	`25`
`26`	`26`	`private static $_template =`
`27`	`27`	`'<?php`
`@@ -61,7 +61,6 @@ public function down(Database $db)`
`61`	`61`	`protected function configure()`
`62`	`62`	`{`
`63`	`63`	`$this`
`64`		`- ->setName($this->getName())`
`65`	`64`	`->setDescription('Generate a blank migration class.')`
`66`	`65`	`->addOption('editor-cmd', null, InputOption::VALUE_OPTIONAL, 'Open file with this command upon creation.')`
`67`	`66`	`->setHelp(<<<'EOT'`
`@@ -103,7 +102,7 @@ public function execute(InputInterface $input, OutputInterface $output)`
`103`	`102`	`*`
`104`	`103`	`* @return string $path`
`105`	`104`	`*`
`106`		`- * @throws InvalidArgumentException`
	`105`	`+ * @throws \InvalidArgumentException`
`107`	`106`	`*/`
`108`	`107`	`protected function generateMigration(Configuration $configuration, InputInterface $input, $version, $up = null, $down = null)`
`109`	`108`	`{`
`@@ -178,12 +177,4 @@ protected function getVersionString()`
`178`	`177`	`{`
`179`	`178`	`return date('YmdHis');`
`180`	`179`	`}`
`181`		`-`
`182`		`- /**`
`183`		`- * @return string`
`184`		`- */`
`185`		`- public function getName()`
`186`		`- {`
`187`		`- return self::NAME;`
`188`		`- }`
`189`	`180`	`}`
Original file line number	Diff line number	Diff line change
`@@ -23,12 +23,11 @@`
`23`	`23`	`*/`
`24`	`24`	`class MigrateCommand extends AbstractCommand`
`25`	`25`	`{`
`26`		`- const NAME = 'mongodb:migrations:migrate';`
	`26`	`+ protected static $defaultName = 'mongodb:migrations:migrate';`
`27`	`27`
`28`	`28`	`protected function configure()`
`29`	`29`	`{`
`30`	`30`	`$this`
`31`		`- ->setName($this->getName())`
`32`	`31`	`->setDescription('Execute a migration to a specified version or the latest available version.')`
`33`	`32`	`->addArgument('version', InputArgument::OPTIONAL, 'The version to migrate to.', null)`
`34`	`33`	`->setHelp(<<<'EOT'`
`@@ -126,9 +125,4 @@ protected function createMigration(Configuration $configuration)`
`126`	`125`	`{`
`127`	`126`	`return new Migration($configuration);`
`128`	`127`	`}`
`129`		`-`
`130`		`- public function getName()`
`131`		`- {`
`132`		`- return self::NAME;`
`133`		`- }`
`134`	`128`	`}`
Original file line number	Diff line number	Diff line change
`@@ -24,12 +24,11 @@`
`24`	`24`	`*/`
`25`	`25`	`class VersionCommand extends AbstractCommand`
`26`	`26`	`{`
`27`		`- const NAME = 'mongodb:migrations:version';`
	`27`	`+ protected static $defaultName = 'mongodb:migrations:version';`
`28`	`28`
`29`	`29`	`protected function configure()`
`30`	`30`	`{`
`31`	`31`	`$this`
`32`		`- ->setName($this->getName())`
`33`	`32`	`->setDescription('Manually add and delete migration versions from the version table.')`
`34`	`33`	`->addArgument('version', InputArgument::REQUIRED, 'The version to add or delete.', null)`
`35`	`34`	`->addOption('add', null, InputOption::VALUE_NONE, 'Add the specified version.')`
`@@ -52,8 +51,8 @@ protected function configure()`
`52`	`51`	`* @param \Symfony\Component\Console\Input\InputInterface`
`53`	`52`	`* @param \Symfony\Component\Console\Output\OutputInterface`
`54`	`53`	`*`
`55`		`- * @throws AntiMattr\MongoDB\Migrations\Exception\UnknownVersionException Throws exception if migration version does not exist`
`56`		`- * @throws InvalidArgumentException`
	`54`	`+ * @throws UnknownVersionException Throws exception if migration version does not exist`
	`55`	`+ * @throws \InvalidArgumentException`
`57`	`56`	`*/`
`58`	`57`	`public function execute(InputInterface $input, OutputInterface $output)`
`59`	`58`	`{`
`@@ -93,9 +92,4 @@ protected function createMigration(Configuration $configuration)`
`93`	`92`	`{`
`94`	`93`	`return new Migration($configuration);`
`95`	`94`	`}`
`96`		`-`
`97`		`- public function getName()`
`98`		`- {`
`99`		`- return self::NAME;`
`100`		`- }`
`101`	`95`	`}`
Original file line number	Diff line number	Diff line change
`@@ -38,7 +38,7 @@ public function testExecuteDownWithoutInteraction()`
`38`	`38`	`$input = new ArgvInput(`
`39`	`39`	`[`
`40`	`40`	`'application-name',`
`41`		`- ExecuteCommand::NAME,`
	`41`	`+ ExecuteCommand::getDefaultName(),`
`42`	`42`	`$numVersion,`
`43`	`43`	`'--down',`
`44`	`44`	`]`
`@@ -89,7 +89,7 @@ public function testExecuteUpWithInteraction()`
`89`	`89`	`$input = new ArgvInput(`
`90`	`90`	`[`
`91`	`91`	`'application-name',`
`92`		`- ExecuteCommand::NAME,`
	`92`	`+ ExecuteCommand::getDefaultName(),`
`93`	`93`	`$numVersion,`
`94`	`94`	`]`
`95`	`95`	`);`
`@@ -167,7 +167,7 @@ public function testExecuteReplayWithoutInteraction()`
`167`	`167`	`$input = new ArgvInput(`
`168`	`168`	`[`
`169`	`169`	`'application-name',`
`170`		`- ExecuteCommand::NAME,`
	`170`	`+ ExecuteCommand::getDefaultName(),`
`171`	`171`	`$numVersion,`
`172`	`172`	`'--up',`
`173`	`173`	`'--replay',`
Original file line number	Diff line number	Diff line change
`@@ -43,7 +43,7 @@ public function testExecute()`
`43`	`43`
`44`	`44`	`$input = new ArgvInput(`
`45`	`45`	`[`
`46`		`- GenerateCommand::NAME,`
	`46`	`+ GenerateCommand::getDefaultName(),`
`47`	`47`	`]`
`48`	`48`	`);`
`49`	`49`
`@@ -87,7 +87,7 @@ public function testExecuteWithInvalidMigrationDirectory()`
`87`	`87`
`88`	`88`	`$input = new ArgvInput(`
`89`	`89`	`[`
`90`		`- GenerateCommand::NAME,`
	`90`	`+ GenerateCommand::getDefaultName(),`
`91`	`91`	`]`
`92`	`92`	`);`
`93`	`93`
Original file line number	Diff line number	Diff line change
`@@ -37,7 +37,7 @@ public function testExecuteWithExectedUnavailableVersionAndInteraction()`
`37`	`37`	`$input = new ArgvInput(`
`38`	`38`	`[`
`39`	`39`	`'application-name',`
`40`		`- MigrateCommand::NAME,`
	`40`	`+ MigrateCommand::getDefaultName(),`
`41`	`41`	`$numVersion,`
`42`	`42`	`]`
`43`	`43`	`);`
`@@ -103,7 +103,7 @@ public function testExecute()`
`103`	`103`	`$numVersion = '000123456789';`
`104`	`104`	`$input = new ArgvInput(`
`105`	`105`	`[`
`106`		`- MigrateCommand::NAME,`
	`106`	`+ MigrateCommand::getDefaultName(),`
`107`	`107`	`$numVersion,`
`108`	`108`	`]`
`109`	`109`	`);`
`@@ -217,6 +217,8 @@ public function testDefaultSecondInteractionWillCancelMigration()`
`217`	`217`
`218`	`218`	`class MigrateCommandStub extends MigrateCommand`
`219`	`219`	`{`
	`220`	`+ protected static $defaultName = 'mongodb:migrations:migrate';`
	`221`	`+`
`220`	`222`	`protected $migration;`
`221`	`223`
`222`	`224`	`public function setMigration(Migration $migration)`
Original file line number	Diff line number	Diff line change
`@@ -53,7 +53,7 @@ public function testExecuteWithoutShowingVersions()`
`53`	`53`	`{`
`54`	`54`	`$input = new ArgvInput(`
`55`	`55`	`[`
`56`		`- StatusCommand::NAME,`
	`56`	`+ StatusCommand::getDefaultName(),`
`57`	`57`	`]`
`58`	`58`	`);`
`59`	`59`
`@@ -213,7 +213,7 @@ public function testExecuteWithShowingVersions()`
`213`	`213`	`{`
`214`	`214`	`$input = new ArgvInput(`
`215`	`215`	`[`
`216`		`- StatusCommand::NAME,`
	`216`	`+ StatusCommand::getDefaultName(),`
`217`	`217`	`'--show-versions',`
`218`	`218`	`]`
`219`	`219`	`);`
Original file line number	Diff line number	Diff line change
`@@ -40,7 +40,7 @@ public function testInvalidArgumentException()`
`40`	`40`	`$numVersion = '123456789012';`
`41`	`41`	`$input = new ArgvInput(`
`42`	`42`	`[`
`43`		`- VersionCommand::NAME,`
	`43`	`+ VersionCommand::getDefaultName(),`
`44`	`44`	`$numVersion,`
`45`	`45`	`]`
`46`	`46`	`);`
`@@ -61,7 +61,7 @@ public function testUnknownVersionException()`
`61`	`61`	`$numVersion = '123456789012';`
`62`	`62`	`$input = new ArgvInput(`
`63`	`63`	`[`
`64`		`- VersionCommand::NAME,`
	`64`	`+ VersionCommand::getDefaultName(),`
`65`	`65`	`$numVersion,`
`66`	`66`	`'--add',`
`67`	`67`	`]`
`@@ -89,7 +89,7 @@ public function testAddVersion()`
`89`	`89`	`$numVersion = '123456789012';`
`90`	`90`	`$input = new ArgvInput(`
`91`	`91`	`[`
`92`		`- VersionCommand::NAME,`
	`92`	`+ VersionCommand::getDefaultName(),`
`93`	`93`	`$numVersion,`
`94`	`94`	`'--add',`
`95`	`95`	`]`
`@@ -137,7 +137,7 @@ public function testDownVersion()`
`137`	`137`	`$numVersion = '123456789012';`
`138`	`138`	`$input = new ArgvInput(`
`139`	`139`	`[`
`140`		`- VersionCommand::NAME,`
	`140`	`+ VersionCommand::getDefaultName(),`
`141`	`141`	`$numVersion,`
`142`	`142`	`'--delete',`
`143`	`143`	`]`
`@@ -188,7 +188,7 @@ public function testDownOnNonMigratedVersionThrowsInvalidArgumentException()`
`188`	`188`	`$numVersion = '123456789012';`
`189`	`189`	`$input = new ArgvInput(`
`190`	`190`	`[`
`191`		`- VersionCommand::NAME,`
	`191`	`+ VersionCommand::getDefaultName(),`
`192`	`192`	`$numVersion,`
`193`	`193`	`'--delete',`
`194`	`194`	`]`
`@@ -235,7 +235,7 @@ public function testUpOnMigratedVersionThrowsInvalidArgumentException()`
`235`	`235`	`$numVersion = '123456789012';`
`236`	`236`	`$input = new ArgvInput(`
`237`	`237`	`[`
`238`		`- VersionCommand::NAME,`
	`238`	`+ VersionCommand::getDefaultName(),`
`239`	`239`	`$numVersion,`
`240`	`240`	`'--add',`
`241`	`241`	`]`