Merge pull request #27 from docusign/bugfix/fixing-tests-and-setting-up-CI-CD

InbarGazit · web-flow · commit c543a5e13131 · 2023-11-16T20:28:09.000-08:00
Fixing tests and setting up CI\CD
diff --git a/.github/workflows/dotnet-desktop.yml b/.github/workflows/dotnet-desktop.yml
@@ -0,0 +1,27 @@
+name: Test .NET
+
+on:
+  push:
+    branches: [ "main" ]
+  pull_request:
+    branches: [ "main" ]
+
+jobs:
+  build:
+
+    runs-on: windows-latest
+
+    steps:
+    - uses: actions/checkout@v3
+    - name: Add .NET support
+      uses: actions/setup-dotnet@v2
+      with:
+        dotnet-version: 6.0.x
+    - name: Add MsBuild
+      uses: microsoft/setup-msbuild@v1.1.3
+    - name: Load dependencies
+      run: dotnet restore DocuSign.MyAPI\DocuSign.MyAPI.sln
+    - name: Build project
+      run: dotnet build DocuSign.MyAPI\DocuSign.MyAPI.sln --no-restore
+    - name: Run tests
+      run: dotnet test DocuSign.MyAPI\DocuSign.MyAPI.sln --no-build --verbosity normal
diff --git a/DocuSign.MyAPI.Tests/ExecuteScenarioServiceTests.cs b/DocuSign.MyAPI.Tests/ExecuteScenarioServiceTests.cs
@@ -43,7 +43,7 @@ public ExecuteScenarioServiceTests()
             var authResult = AuthenticateResult.Success(
                 new AuthenticationTicket(new ClaimsPrincipal(), "DocuSign"));
 
-            authResult.Properties.StoreTokens(new[]
+            authResult.Properties?.StoreTokens(new[]
             {
               new AuthenticationToken { Name = "access_token", Value = "token_123" }
             });
@@ -694,7 +694,7 @@ public async Task ExecuteScenarioStep_CorrectArgument_ReturnCorrectResponse()
                                 new Parameter
                                 {
                                     RequestParameterPath = "accountId",
-                                    Source = null,
+                                    Source = string.Empty,
                                     In = "Path"
                                 }
                             }
@@ -706,7 +706,7 @@ public async Task ExecuteScenarioStep_CorrectArgument_ReturnCorrectResponse()
             var expectedBody = JToken.Parse("{\"name\": \"Vas\", \"email\": \"val2\"}").ToString();
 
             //Act
-            var response = await _executeScenarioService.ExecuteScenarioStep(scenarioNumber, stepName, parameters, null);
+            var response = await _executeScenarioService.ExecuteScenarioStep(scenarioNumber, stepName, parameters, new StepResponse[]{}, new StepParameters[]{});
 
             //Assert
             Assert.Equal("https://testApi.com/api/createEntity/accountId123", response.API);
@@ -743,7 +743,7 @@ public async Task ExecuteScenarioStep_CorrectArgumentsWithRandomParameter_Return
                                 new Parameter
                                 {
                                     RequestParameterPath = "accountId",
-                                    Source = null,
+                                    Source = string.Empty,
                                     In = "Path"
                                 }
                             }
@@ -756,7 +756,7 @@ public async Task ExecuteScenarioStep_CorrectArgumentsWithRandomParameter_Return
             var expectedBody = JToken.Parse("{\"name\": \"User 25 name\", \"email\": \"val2\"}").ToString();
 
             //Act
-            var response = await _executeScenarioService.ExecuteScenarioStep(scenarioNumber, stepName, parameters, null);
+            var response = await _executeScenarioService.ExecuteScenarioStep(scenarioNumber, stepName, parameters, new StepResponse[]{}, new StepParameters[]{});
 
             //Assert
             Assert.Equal("https://testApi.com/api/createEntity/accountId123", response.API);
@@ -793,7 +793,7 @@ public async Task ExecuteScenarioStep_InvalidParametersPrompt_Skips_ReturnsCorre
                                 new Parameter
                                 {
                                     RequestParameterPath = "accountId",
-                                    Source = null,
+                                    Source = string.Empty,
                                     In = "Path"
                                 }
                             }
@@ -805,7 +805,7 @@ public async Task ExecuteScenarioStep_InvalidParametersPrompt_Skips_ReturnsCorre
             var expectedBody = JToken.Parse("{\"name\": \"[name]\", \"email\": \"val2\"}").ToString();
 
             //Act
-            var response = await _executeScenarioService.ExecuteScenarioStep(scenarioNumber, stepName, parameters, null);
+            var response = await _executeScenarioService.ExecuteScenarioStep(scenarioNumber, stepName, parameters, new StepResponse[]{}, new StepParameters[]{});
 
             //Assert
             Assert.Equal("https://testApi.com/api/createEntity/accountId123", response.API);
@@ -824,7 +824,7 @@ public async Task ExecuteScenarioStep_IncorrectScenario_ThrowNotFoundScenarioExc
             var parameters = "[{\"Name\": \"Vas\", \"stepName\": \"TestStep\"}]";
 
             //Act
-            var result = () => _executeScenarioService.ExecuteScenarioStep(scenarioNumber, stepName, parameters, null);
+            var result = () => _executeScenarioService.ExecuteScenarioStep(scenarioNumber, stepName, parameters, new StepResponse[]{}, new StepParameters[]{});
 
             //Assert
             await result.Should().ThrowAsync<NotFoundStepException>().WithMessage("Step with name TestStep is not found.");
@@ -872,7 +872,7 @@ public async Task ExecuteScenario_CorrectArgument_ReturnsCorrectResponse()
                                 new Parameter
                                 {
                                     RequestParameterPath = "accountId",
-                                    Source = null,
+                                    Source = string.Empty,
                                     In = "Path"
                                 }
                             }
@@ -921,7 +921,7 @@ public async Task ExecuteScenario_CorrectArgumentWithRandom_ReturnsCorrectRespon
                                 new Parameter
                                 {
                                     RequestParameterPath = "accountId",
-                                    Source = null,
+                                    Source = string.Empty,
                                     In = "Path"
                                 }
                             }
@@ -989,7 +989,7 @@ public async Task ExecuteScenario_SeveralSteps_ReturnsCorrectResponse()
                                 new Parameter
                                 {
                                     RequestParameterPath = "accountId",
-                                    Source = null,
+                                    Source = string.Empty,
                                     In = "Path"
                                 }
                             }
@@ -1087,7 +1087,7 @@ public async Task ExecuteScenario_SeveralStepsAndSeveralIterations_ReturnsCorrec
                                 new Parameter
                                 {
                                     RequestParameterPath = "accountId",
-                                    Source = null,
+                                    Source = string.Empty,
                                     In = "Path"
                                 }
                             }
@@ -1184,7 +1184,7 @@ public async Task ExecuteScenario_SeveralSteps_OneStepFailed_ExecutionOfOtherSte
                                 new Parameter
                                 {
                                     RequestParameterPath = "accountId",
-                                    Source = null,
+                                    Source = string.Empty,
                                     In = "Path"
                                 }
                             }

Original file line number	Diff line number	Diff line change
`@@ -43,7 +43,7 @@ public ExecuteScenarioServiceTests()`
`43`	`43`	`var authResult = AuthenticateResult.Success(`
`44`	`44`	`new AuthenticationTicket(new ClaimsPrincipal(), "DocuSign"));`
`45`	`45`
`46`		`- authResult.Properties.StoreTokens(new[]`
	`46`	`+ authResult.Properties?.StoreTokens(new[]`
`47`	`47`	`{`
`48`	`48`	`new AuthenticationToken { Name = "access_token", Value = "token_123" }`
`49`	`49`	`});`
`@@ -694,7 +694,7 @@ public async Task ExecuteScenarioStep_CorrectArgument_ReturnCorrectResponse()`
`694`	`694`	`new Parameter`
`695`	`695`	`{`
`696`	`696`	`RequestParameterPath = "accountId",`
`697`		`- Source = null,`
	`697`	`+ Source = string.Empty,`
`698`	`698`	`In = "Path"`
`699`	`699`	`}`
`700`	`700`	`}`
`@@ -706,7 +706,7 @@ public async Task ExecuteScenarioStep_CorrectArgument_ReturnCorrectResponse()`
`706`	`706`	`var expectedBody = JToken.Parse("{\"name\": \"Vas\", \"email\": \"val2\"}").ToString();`
`707`	`707`
`708`	`708`	`//Act`
`709`		`- var response = await _executeScenarioService.ExecuteScenarioStep(scenarioNumber, stepName, parameters, null);`
	`709`	`+ var response = await _executeScenarioService.ExecuteScenarioStep(scenarioNumber, stepName, parameters, new StepResponse[]{}, new StepParameters[]{});`
`710`	`710`
`711`	`711`	`//Assert`
`712`	`712`	`Assert.Equal("https://testApi.com/api/createEntity/accountId123", response.API);`
`@@ -743,7 +743,7 @@ public async Task ExecuteScenarioStep_CorrectArgumentsWithRandomParameter_Return`
`743`	`743`	`new Parameter`
`744`	`744`	`{`
`745`	`745`	`RequestParameterPath = "accountId",`
`746`		`- Source = null,`
	`746`	`+ Source = string.Empty,`
`747`	`747`	`In = "Path"`
`748`	`748`	`}`
`749`	`749`	`}`
`@@ -756,7 +756,7 @@ public async Task ExecuteScenarioStep_CorrectArgumentsWithRandomParameter_Return`
`756`	`756`	`var expectedBody = JToken.Parse("{\"name\": \"User 25 name\", \"email\": \"val2\"}").ToString();`
`757`	`757`
`758`	`758`	`//Act`
`759`		`- var response = await _executeScenarioService.ExecuteScenarioStep(scenarioNumber, stepName, parameters, null);`
	`759`	`+ var response = await _executeScenarioService.ExecuteScenarioStep(scenarioNumber, stepName, parameters, new StepResponse[]{}, new StepParameters[]{});`
`760`	`760`
`761`	`761`	`//Assert`
`762`	`762`	`Assert.Equal("https://testApi.com/api/createEntity/accountId123", response.API);`
`@@ -793,7 +793,7 @@ public async Task ExecuteScenarioStep_InvalidParametersPrompt_Skips_ReturnsCorre`
`793`	`793`	`new Parameter`
`794`	`794`	`{`
`795`	`795`	`RequestParameterPath = "accountId",`
`796`		`- Source = null,`
	`796`	`+ Source = string.Empty,`
`797`	`797`	`In = "Path"`
`798`	`798`	`}`
`799`	`799`	`}`
`@@ -805,7 +805,7 @@ public async Task ExecuteScenarioStep_InvalidParametersPrompt_Skips_ReturnsCorre`
`805`	`805`	`var expectedBody = JToken.Parse("{\"name\": \"[name]\", \"email\": \"val2\"}").ToString();`
`806`	`806`
`807`	`807`	`//Act`
`808`		`- var response = await _executeScenarioService.ExecuteScenarioStep(scenarioNumber, stepName, parameters, null);`
	`808`	`+ var response = await _executeScenarioService.ExecuteScenarioStep(scenarioNumber, stepName, parameters, new StepResponse[]{}, new StepParameters[]{});`
`809`	`809`
`810`	`810`	`//Assert`
`811`	`811`	`Assert.Equal("https://testApi.com/api/createEntity/accountId123", response.API);`
`@@ -824,7 +824,7 @@ public async Task ExecuteScenarioStep_IncorrectScenario_ThrowNotFoundScenarioExc`
`824`	`824`	`var parameters = "[{\"Name\": \"Vas\", \"stepName\": \"TestStep\"}]";`
`825`	`825`
`826`	`826`	`//Act`
`827`		`- var result = () => _executeScenarioService.ExecuteScenarioStep(scenarioNumber, stepName, parameters, null);`
	`827`	`+ var result = () => _executeScenarioService.ExecuteScenarioStep(scenarioNumber, stepName, parameters, new StepResponse[]{}, new StepParameters[]{});`
`828`	`828`
`829`	`829`	`//Assert`
`830`	`830`	`await result.Should().ThrowAsync<NotFoundStepException>().WithMessage("Step with name TestStep is not found.");`
`@@ -872,7 +872,7 @@ public async Task ExecuteScenario_CorrectArgument_ReturnsCorrectResponse()`
`872`	`872`	`new Parameter`
`873`	`873`	`{`
`874`	`874`	`RequestParameterPath = "accountId",`
`875`		`- Source = null,`
	`875`	`+ Source = string.Empty,`
`876`	`876`	`In = "Path"`
`877`	`877`	`}`
`878`	`878`	`}`
`@@ -921,7 +921,7 @@ public async Task ExecuteScenario_CorrectArgumentWithRandom_ReturnsCorrectRespon`
`921`	`921`	`new Parameter`
`922`	`922`	`{`
`923`	`923`	`RequestParameterPath = "accountId",`
`924`		`- Source = null,`
	`924`	`+ Source = string.Empty,`
`925`	`925`	`In = "Path"`
`926`	`926`	`}`
`927`	`927`	`}`
`@@ -989,7 +989,7 @@ public async Task ExecuteScenario_SeveralSteps_ReturnsCorrectResponse()`
`989`	`989`	`new Parameter`
`990`	`990`	`{`
`991`	`991`	`RequestParameterPath = "accountId",`
`992`		`- Source = null,`
	`992`	`+ Source = string.Empty,`
`993`	`993`	`In = "Path"`
`994`	`994`	`}`
`995`	`995`	`}`
`@@ -1087,7 +1087,7 @@ public async Task ExecuteScenario_SeveralStepsAndSeveralIterations_ReturnsCorrec`
`1087`	`1087`	`new Parameter`
`1088`	`1088`	`{`
`1089`	`1089`	`RequestParameterPath = "accountId",`
`1090`		`- Source = null,`
	`1090`	`+ Source = string.Empty,`
`1091`	`1091`	`In = "Path"`
`1092`	`1092`	`}`
`1093`	`1093`	`}`
`@@ -1184,7 +1184,7 @@ public async Task ExecuteScenario_SeveralSteps_OneStepFailed_ExecutionOfOtherSte`
`1184`	`1184`	`new Parameter`
`1185`	`1185`	`{`
`1186`	`1186`	`RequestParameterPath = "accountId",`
`1187`		`- Source = null,`
	`1187`	`+ Source = string.Empty,`
`1188`	`1188`	`In = "Path"`
`1189`	`1189`	`}`
`1190`	`1190`	`}`