Refactor deploy workflow with testing and Docker build improvements

Author: dmitryesin

.github/workflows/deploy.yml

@@ -8,44 +8,79 @@ on:
   workflow_dispatch:
 
 jobs:
+  test:
+    runs-on: ubuntu-latest
+    steps:
+      - name: Checkout
+        uses: actions/checkout@v4
+
+      - name: Install Python deps
+        run: |
+          sudo apt-get update
+          sudo apt-get install -y python3-pip
+          pip3 install --upgrade pip
+          pip3 install --no-cache-dir -r requirements.txt
+      - name: Run Python tests
+        run: |
+          # Run Python tests
+
+      - name: Install Maven
+        run: |
+          apt-get update && \
+          apt-get install -y --no-install-recommends maven && \
+          apt-get clean && \
+          rm -rf /var/lib/apt/lists/*
+      - name: Run Maven tests
+        run: |
+          # Run Maven tests
+
   build-and-push:
+    needs: test
     runs-on: ubuntu-latest
     steps:
       - name: Checkout
-        uses: actions/checkout@v3
+        uses: actions/checkout@v4
 
-      - name: Log in to Docker Registry
+      - name: Verify DockerHub credentials
+        run: |
+          if [ -z "${{ secrets.DOCKERHUB_USERNAME }}" ] || [ -z "${{ secrets.DOCKERHUB_PASSWORD }}" ]; then
+            echo "Missing DockerHub credentials"
+            exit 1
+          fi
+
+      - name: Log in to Docker Hub
         if: github.ref == 'refs/heads/main'
-        uses: docker/login-action@v2
+        uses: docker/login-action@v3
         with:
           registry: docker.io
           username: ${{ secrets.DOCKERHUB_USERNAME }}
           password: ${{ secrets.DOCKERHUB_PASSWORD }}
 
-      - name: Build diffy-bot-client Image
-        run: |
-          docker build -t ${{ secrets.DOCKERHUB_USERNAME }}/diffy-bot-client:latest -f solver-bot/Dockerfile .
-
-      - name: Build diffy-bot-server Image
-        run: |
-          docker build -t ${{ secrets.DOCKERHUB_USERNAME }}/diffy-bot-server:latest -f solver-common/Dockerfile .
-
-      - name: Push diffy-bot-client Image
+      - name: Build and push diffy-bot-client
         if: github.ref == 'refs/heads/main'
-        run: |
-          docker push ${{ secrets.DOCKERHUB_USERNAME }}/diffy-bot-client:latest
+        uses: docker/build-push-action@v4
+        with:
+          context: .
+          file: solver-bot/Dockerfile
+          push: true
+          tags: ${{ secrets.DOCKERHUB_USERNAME }}/diffy-bot-client:latest
 
-      - name: Push diffy-bot-server Image
+      - name: Build and push diffy-bot-server
         if: github.ref == 'refs/heads/main'
-        run: |
-          docker push ${{ secrets.DOCKERHUB_USERNAME }}/diffy-bot-server:latest
+        uses: docker/build-push-action@v4
+        with:
+          context: .
+          file: solver-common/Dockerfile
+          push: true
+          tags: ${{ secrets.DOCKERHUB_USERNAME }}/diffy-bot-server:latest
 
   deploy:
     needs: build-and-push
     runs-on: ubuntu-latest
     steps:
       - name: Checkout
-        uses: actions/checkout@v3
+        uses: actions/checkout@v4
+
       - name: Create .env file from secrets
         run: |
           echo "CLIENT_API_KEY=${{ secrets.CLIENT_API_KEY }}" >> .env