Bug fix: properties from the Object prototype was leaking into the keywords dictionary in toPng.

dmester · dmester · commit 6a0bdb7c2d01 · 2019-09-14T16:15:14.000+02:00
diff --git a/lib/canvas.js b/lib/canvas.js
@@ -108,7 +108,9 @@ Canvas.prototype.toPng = function Canvas_toPng(keywords) {
     
     if (keywords) {
         for (var key in keywords) {
-            png.writeTextualData(key, keywords[key]);
+            if (keywords.hasOwnProperty(key)) {
+                png.writeTextualData(key, keywords[key]);
+            }
         }
     }
 

Original file line number	Diff line number	Diff line change
`@@ -108,7 +108,9 @@ Canvas.prototype.toPng = function Canvas_toPng(keywords) {`
`108`	`108`
`109`	`109`	`if (keywords) {`
`110`	`110`	`for (var key in keywords) {`
`111`		`- png.writeTextualData(key, keywords[key]);`
	`111`	`+ if (keywords.hasOwnProperty(key)) {`
	`112`	`+ png.writeTextualData(key, keywords[key]);`
	`113`	`+ }`
`112`	`114`	`}`
`113`	`115`	`}`
`114`	`116`