Merge pull request #4729 from rainers/issue16385

dnadlinger · web-flow · commit d753c8e3773f · 2016-08-14T13:27:03.000+02:00
Fix issue 16385:  std.range: undefined behaviour when skipping over 0xff in string.popFront
diff --git a/std/range/primitives.d b/std/range/primitives.d
@@ -2109,6 +2109,11 @@ if (isNarrowString!(C[]))
             //ptr is used to avoid unnnecessary bounds checking.
             str = str.ptr[1 .. str.length];
         }
+        else if (c == 0xff)
+        {
+            // bsr undefined for 0
+            str = str.ptr[1 .. str.length];
+        }
         else
         {
              import core.bitop : bsr;

Original file line number	Diff line number	Diff line change
`@@ -2109,6 +2109,11 @@ if (isNarrowString!(C[]))`
`2109`	`2109`	`//ptr is used to avoid unnnecessary bounds checking.`
`2110`	`2110`	`str = str.ptr[1 .. str.length];`
`2111`	`2111`	`}`
	`2112`	`+ else if (c == 0xff)`
	`2113`	`+ {`
	`2114`	`+ // bsr undefined for 0`
	`2115`	`+ str = str.ptr[1 .. str.length];`
	`2116`	`+ }`
`2112`	`2117`	`else`
`2113`	`2118`	`{`
`2114`	`2119`	`import core.bitop : bsr;`