Skip to content

Commit 8dd93ad

Browse files
authored
Merge pull request #34 from MartinNowak/fixTrelloComment
fix Trello PR link
2 parents 57c2df1 + 2743edb commit 8dd93ad

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

source/dlangbot/app.d

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -196,7 +196,7 @@ void handlePR(string action, PullRequest pr)
196196
updateGithubComment(action, refs, descs, pr.commentsURL);
197197

198198
if (runTrello)
199-
updateTrelloCard(action, pr.url, refs, descs);
199+
updateTrelloCard(action, pr.htmlURL, refs, descs);
200200

201201
// wait until builds for the current push are created
202202
setTimer(30.seconds, { dedupTravisBuilds(action, pr.repoSlug, pr.number); });

source/dlangbot/github.d

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -143,7 +143,7 @@ struct PullRequest
143143
string commentsURL() const { return "%s/repos/%s/issues/%d/comments".format(githubAPIURL, repoSlug, number); }
144144
string commitsURL() const { return "%s/repos/%s/pulls/%d/commits".format(githubAPIURL, repoSlug, number); }
145145
string eventsURL() const { return "%s/repos/%s/issues/%d/events".format(githubAPIURL, repoSlug, number); }
146-
string url() const { return "%s/repos/%s/pulls/%d".format(githubAPIURL, repoSlug, number); }
146+
string htmlURL() const { return "https://github.com/%s/pull/%d".format(repoSlug, number); }
147147
}
148148

149149
alias LabelsAndCommits = Tuple!(Json[], "labels", Json[], "commits");

0 commit comments

Comments
 (0)