Skip to content

Commit a463e3c

Browse files
committed
Fixing some codacy complaints
1 parent bc30a6a commit a463e3c

File tree

1 file changed

+72
-25
lines changed

1 file changed

+72
-25
lines changed

src/main/java/uk/co/evoco/webdriver/WebDriverListener.java

Lines changed: 72 additions & 25 deletions
Original file line numberDiff line numberDiff line change
@@ -34,29 +34,53 @@ public void setScreenshotDirectory(File screenshotDirectory) {
3434
this.screenshotDirectory = screenshotDirectory;
3535
}
3636

37-
public void beforeAlertAccept(WebDriver webDriver) {}
37+
public void beforeAlertAccept(WebDriver webDriver) {
38+
// nothing yet
39+
}
3840

39-
public void afterAlertAccept(WebDriver webDriver) {}
41+
public void afterAlertAccept(WebDriver webDriver) {
42+
// nothing yet
43+
}
4044

41-
public void afterAlertDismiss(WebDriver webDriver) {}
45+
public void afterAlertDismiss(WebDriver webDriver) {
46+
// nothing yet
47+
}
4248

43-
public void beforeAlertDismiss(WebDriver webDriver) {}
49+
public void beforeAlertDismiss(WebDriver webDriver) {
50+
// nothing yet
51+
}
4452

45-
public void beforeNavigateTo(String s, WebDriver webDriver) {}
53+
public void beforeNavigateTo(String s, WebDriver webDriver) {
54+
// nothing yet
55+
}
4656

47-
public void afterNavigateTo(String s, WebDriver webDriver) {}
57+
public void afterNavigateTo(String s, WebDriver webDriver) {
58+
// nothing yet
59+
}
4860

49-
public void beforeNavigateBack(WebDriver webDriver) {}
61+
public void beforeNavigateBack(WebDriver webDriver) {
62+
// nothing yet
63+
}
5064

51-
public void afterNavigateBack(WebDriver webDriver) {}
65+
public void afterNavigateBack(WebDriver webDriver) {
66+
// nothing yet
67+
}
5268

53-
public void beforeNavigateForward(WebDriver webDriver) {}
69+
public void beforeNavigateForward(WebDriver webDriver) {
70+
// nothing yet
71+
}
5472

55-
public void afterNavigateForward(WebDriver webDriver) {}
73+
public void afterNavigateForward(WebDriver webDriver) {
74+
// nothing yet
75+
}
5676

57-
public void beforeNavigateRefresh(WebDriver webDriver) {}
77+
public void beforeNavigateRefresh(WebDriver webDriver) {
78+
// nothing yet
79+
}
5880

59-
public void afterNavigateRefresh(WebDriver webDriver) {}
81+
public void afterNavigateRefresh(WebDriver webDriver) {
82+
// nothing yet
83+
}
6084

6185
/**
6286
* Before each webDriver.findBy or @FindBy we want to make sure that we are supply elements
@@ -70,7 +94,9 @@ public void beforeFindBy(By by, WebElement webElement, WebDriver webDriver) {
7094
new WebDriverWait(webDriver, WEBDRIVER_WAIT_TIMEOUT).until(ExpectedConditions.presenceOfElementLocated(by));
7195
}
7296

73-
public void afterFindBy(By by, WebElement webElement, WebDriver webDriver) {}
97+
public void afterFindBy(By by, WebElement webElement, WebDriver webDriver) {
98+
// nothing yet
99+
}
74100

75101
/**
76102
* Before we interact with any methods (which is anytime we click() on anything) we want to do a state
@@ -85,19 +111,33 @@ public void beforeClickOn(WebElement webElement, WebDriver webDriver) {
85111
new WebDriverWait(webDriver, WEBDRIVER_WAIT_TIMEOUT).until(ExpectedConditions.elementToBeClickable(webElement));
86112
}
87113

88-
public void afterClickOn(WebElement webElement, WebDriver webDriver) {}
114+
public void afterClickOn(WebElement webElement, WebDriver webDriver) {
115+
// nothing yet
116+
}
89117

90-
public void beforeChangeValueOf(WebElement webElement, WebDriver webDriver, CharSequence[] charSequences) {}
118+
public void beforeChangeValueOf(WebElement webElement, WebDriver webDriver, CharSequence[] charSequences) {
119+
// nothing yet
120+
}
91121

92-
public void afterChangeValueOf(WebElement webElement, WebDriver webDriver, CharSequence[] charSequences) {}
122+
public void afterChangeValueOf(WebElement webElement, WebDriver webDriver, CharSequence[] charSequences) {
123+
// nothing yet
124+
}
93125

94-
public void beforeScript(String s, WebDriver webDriver) {}
126+
public void beforeScript(String s, WebDriver webDriver) {
127+
// nothing yet
128+
}
95129

96-
public void afterScript(String s, WebDriver webDriver) {}
130+
public void afterScript(String s, WebDriver webDriver) {
131+
// nothing yet
132+
}
97133

98-
public void beforeSwitchToWindow(String s, WebDriver webDriver) {}
134+
public void beforeSwitchToWindow(String s, WebDriver webDriver) {
135+
// nothing yet
136+
}
99137

100-
public void afterSwitchToWindow(String s, WebDriver webDriver) {}
138+
public void afterSwitchToWindow(String s, WebDriver webDriver) {
139+
// nothing yet
140+
}
101141

102142
/**
103143
* If we have an exception, lets create a screenshot so we can see the page as it happened.
@@ -119,12 +159,19 @@ public void onException(Throwable throwable, WebDriver webDriver) {
119159
}
120160
}
121161

122-
public <X> void beforeGetScreenshotAs(OutputType<X> outputType) {}
123-
124-
public <X> void afterGetScreenshotAs(OutputType<X> outputType, X x) {}
162+
public <X> void beforeGetScreenshotAs(OutputType<X> outputType) {
163+
// nothing yet
164+
}
125165

126-
public void beforeGetText(WebElement webElement, WebDriver webDriver) {}
166+
public <X> void afterGetScreenshotAs(OutputType<X> outputType, X x) {
167+
// nothing yet
168+
}
127169

128-
public void afterGetText(WebElement webElement, WebDriver webDriver, String s) {}
170+
public void beforeGetText(WebElement webElement, WebDriver webDriver) {
171+
// nothing yet
172+
}
129173

174+
public void afterGetText(WebElement webElement, WebDriver webDriver, String s) {
175+
// nothing yet
176+
}
130177
}

0 commit comments

Comments
 (0)