Skip to content

Commit b0a60e8

Browse files
authored
Added review comments!!
1 parent 56bbf9b commit b0a60e8

File tree

3 files changed

+19
-28
lines changed

3 files changed

+19
-28
lines changed

templates/ibm-spectrum-scale-master.template

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -195,7 +195,7 @@
195195
"Type": "String"
196196
},
197197
"SpectrumS3Bucket": {
198-
"Description": "The name of the S3 bucket to be used for data store. If you choose not to create an S3 bucket, simply leave the SpectrumS3Bucket parameter blank, and a new S3 buicket will be created by this Quick Start.",
198+
"Description": "The name of the S3 bucket to be used for data store. If you choose not to create an S3 bucket, simply leave the SpectrumS3Bucket parameter blank, and a new S3 bucket will be created by this Quick Start.",
199199
"AllowedPattern": "^[0-9a-z]?([0-9a-z-/]*[0-9a-z])*$",
200200
"Type": "String",
201201
"MinLength": "0",

templates/ibm-spectrum-scale-subnet.template

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -45,6 +45,16 @@
4545
"ConstraintDescription": "Two Availability Zones must be added."
4646
}
4747
},
48+
"Mappings": {
49+
"AWSAMIRegionMap": {
50+
"AMI": {
51+
"AWSNATHVM": "amzn-ami-vpc-nat-hvm-2017.03.0.20170401-x86_64-ebs"
52+
},
53+
"us-gov-west-1": {
54+
"AWSNATHVM": "ami-3f0a8f5e"
55+
}
56+
}
57+
},
4858
"Conditions":{
4959
"GovCloudCondition": {
5060
"Fn::Equals": [

templates/ibm-spectrum-scale.template

Lines changed: 8 additions & 27 deletions
Original file line numberDiff line numberDiff line change
@@ -166,7 +166,7 @@
166166
]
167167
},
168168
"DataReplica": {
169-
"Description": "Number of replica copies of data across the all cluster nodes on two AZs.",
169+
"Description": "Number of replica copies of data across the cluster nodes.",
170170
"Type": "Number",
171171
"Default": "2",
172172
"AllowedValues": [
@@ -576,7 +576,7 @@
576576
"1"
577577
]
578578
},
579-
"SpectrumS3BucketProvided": {
579+
"SpectrumS3BucketNotProvided": {
580580
"Fn::Equals": [
581581
{
582582
"Ref": "SpectrumS3Bucket"
@@ -770,9 +770,9 @@
770770
"ec2:DescribeInstanceRecoveryAttribute",
771771
"ec2:RecoverInstances",
772772
"ssm:DescribeParameters",
773-
"ssm:PutParameter",
774-
"ssm:GetParameters",
775-
"ssm:DeleteParameter"
773+
"ssm:PutParameter",
774+
"ssm:GetParameters",
775+
"ssm:DeleteParameter"
776776
],
777777
"Effect": "Allow"
778778
},
@@ -970,25 +970,7 @@
970970
},
971971
"SpectrumScaleS3Bucket": {
972972
"Type": "AWS::S3::Bucket",
973-
"Condition": "SpectrumS3BucketProvided",
974-
"Properties": {
975-
"Tags": [
976-
{
977-
"Key": "Name",
978-
"Value": {
979-
"Fn::Join": [
980-
"",
981-
[
982-
{
983-
"Ref": "AWS::StackId"
984-
},
985-
" - spectrum-scale-bucket"
986-
]
987-
]
988-
}
989-
}
990-
]
991-
}
973+
"Condition": "SpectrumS3BucketNotProvided"
992974
},
993975
"ServerNodeLaunchConfig": {
994976
"Type": "AWS::AutoScaling::LaunchConfiguration",
@@ -1569,7 +1551,6 @@
15691551
"IFS=' ' read -a adminArr <<< `cat /var/log/instance_server.out | awk '{print $4,$1}' | sort | awk '{print $2}'`\n",
15701552
"ADMIN_INS=${adminArr[0]}\n",
15711553
"echo ADMIN_INS=$ADMIN_INS\n",
1572-
"echo adminArr:$adminArr\n",
15731554
"adminNode=$(cat /var/log/instance_server.out | grep ${adminArr[0]} | awk '{print $2}')\n",
15741555
"echo adminNode=$adminNode\n",
15751556
"if [ $INSTANCE_ID == $ADMIN_INS ]\n",
@@ -2774,7 +2755,7 @@
27742755
"02_gpfs-compute-setup": {
27752756
"command": "/usr/bin/gpfs-compute-setup.sh | while IFS= read -r line; do printf \"%s [INFO] %s\n\" \"$(date)\" \"$line\"; done >> /var/log/gpfs/gpfs-compute-setup.log 2>&1"
27762757
},
2777-
"03_gpfs-compute-setup": {
2758+
"03_gpfs-passwordless-setup": {
27782759
"command": "/usr/bin/gpfs-passwordless-setup.sh | while IFS= read -r line; do printf \"%s [INFO] %s\n\" \"$(date)\" \"$line\"; done >> /var/log/gpfs/gpfs-passwordless-setup.log 2>&1"
27792760
},
27802761
"04_gpfs-auto-recovery-setup": {
@@ -3038,7 +3019,7 @@
30383019
"SpectrumS3Bucket": {
30393020
"Value": {
30403021
"Fn::If": [
3041-
"SpectrumS3BucketProvided",
3022+
"SpectrumS3BucketNotProvided",
30423023
{
30433024
"Ref": "SpectrumScaleS3Bucket"
30443025
},

0 commit comments

Comments
 (0)