Skip to content

Conversation

@ascalotoru
Copy link

Summary

This PR replaces the manual environment variable mapping logic in
the irisapp and irisworker Helm charts with Kubernetes-native envFrom
references. This allows the deployments to load environment variables
directly from one or more secrets.

Motivation

Previously, only a single secret could be used, and adding or removing
environment variables required modifying the Helm template. Using envFrom
simplifies the templates, improves maintainability, and aligns with
Kubernetes best practices.

Changes

  • Replaced the loop for POSTGRES_* variables in irisapp with envFrom.
  • Added support for multiple secrets in both irisapp and irisworker via envFromSecrets.
  • Adjusted values.yaml comments to clarify plural/multiple secrets support.

Benefits

  • Cleaner and shorter Helm templates
  • Multiple secret support
  • No need to hardcode variable names
  • Easier maintenance and consistency across environments

@coderabbitai
Copy link

coderabbitai bot commented Oct 14, 2025

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

🗂️ Base branches to auto review (1)
  • api_*

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@ascalotoru ascalotoru changed the title Simplify environment variable injection in Helm charts using envFrom [IMP] Simplify environment variable injection in Helm charts using envFrom Oct 14, 2025
@ascalotoru ascalotoru force-pushed the feature/helm-envfrom-refactor branch from b7bbdfd to ec389cb Compare October 14, 2025 15:33
Replace manual env variable mapping with Kubernetes-native envFrom
for both irisapp and irisworker deployments. Supports multiple secrets
and improves maintainability of the Helm chart.
@ascalotoru ascalotoru force-pushed the feature/helm-envfrom-refactor branch from ec389cb to d08b2b2 Compare October 14, 2025 16:23
@ascalotoru ascalotoru marked this pull request as draft October 14, 2025 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant