Skip to content

Commit 8a8c309

Browse files
committed
Avoided returning a tuple
1 parent 16dc916 commit 8a8c309

File tree

3 files changed

+4
-4
lines changed

3 files changed

+4
-4
lines changed

source/app/blueprints/rest/case/case_assets_routes.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -169,8 +169,8 @@ def deprecated_add_asset(caseid):
169169
request_data = call_modules_hook('on_preload_asset_create', data=request.get_json(), caseid=caseid)
170170
ioc_links = request_data.get('ioc_links')
171171
asset = asset_schema.load(request_data)
172-
msg, created_asset = assets_create(iris_current_user, caseid, asset, ioc_links)
173-
return response_success(msg, asset_schema.dump(created_asset))
172+
created_asset = assets_create(iris_current_user, caseid, asset, ioc_links)
173+
return response_success('Asset added', asset_schema.dump(created_asset))
174174
except ValidationError as e:
175175
return response_error('Data error', data=e.messages)
176176
except BusinessProcessingError as e:

source/app/blueprints/rest/v2/case_routes/assets.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -89,7 +89,7 @@ def create(self, case_identifier):
8989
request_data = call_deprecated_on_preload_modules_hook('asset_create', request.get_json(), case_identifier)
9090
ioc_links = request_data.get('ioc_links')
9191
asset = self._schema.load(request_data)
92-
_, create_asset = assets_create(iris_current_user, case_identifier, asset, ioc_links)
92+
create_asset = assets_create(iris_current_user, case_identifier, asset, ioc_links)
9393
return response_api_created(self._schema.dump(create_asset))
9494

9595
except ValidationError as e:

source/app/business/assets.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,7 @@ def assets_create(user, case_identifier, asset: CaseAssets, ioc_links):
5353

5454
if asset:
5555
track_activity(f'added asset "{asset.asset_name}"', caseid=case_identifier)
56-
return 'Asset added', asset
56+
return asset
5757

5858
raise BusinessProcessingError('Unable to create asset for internal reasons')
5959

0 commit comments

Comments
 (0)