Improved error handling by adding a fail case and removed redundant reload_assets function call

Author: derickdiaz

ui/src/pages/case.asset.js

@@ -187,16 +187,19 @@ function delete_selected_assets() {
         let cid = get_caseid();
         asset_ids.forEach(asset_id => {
             let url = `/api/v2/cases/${cid}/assets/${asset_id}`;
-            delete_request_api(url).done((data, textStatus) => {
-                if (textStatus === "nocontent") {
-                    reload_assets();
-                    notify_success(`Assets deleted: ${asset_id}`);
-                    return;
-                }
-                notify_error(`Unable to delete asset: ${asset_id}`);
-            });
+            delete_request_api(url)
+                .done((data, textStatus) => {
+                    if (textStatus === "nocontent") {
+                        reload_assets();
+                        notify_success(`Asset deleted: ${asset_id}`);
+                        return;
+                    }
+                    notify_error(`Unable to delete asset: ${asset_id}`);
+                })
+                .fail((jqXHR, textStatus, errorThrown) => {
+                    notify_error(`Unable to delete asset: ${asset_id}`);
+                })
         });
-        reload_assets();
         $('#modal_add_asset').modal('hide');
     })
 }