feat: asset canister exposes state info #4434
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
viviveevee
changed the title
ggreif
reviewed
Dec 8, 2025
|
|
||
| type StateInfo = record { | ||
| last_state_update_timestamp: nat64; | ||
| state_hash: opt text; |
Contributor
There was a problem hiding this comment.
I see that this is hex-encoded. Did you also consider returning it as a blob?
ggreif
approved these changes
Dec 8, 2025
Contributor
There was a problem hiding this comment.
LGTM. Just another thought: One could also send the last known hash(+stamp) when requesting an asset and the canister could abort when recent. Otherwise it would include its last state hash in its response along with the asset. This would make an extra endpoint unnecessary.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
To make integrity verification easier,
compute_state_hashshould be accompanied with a way to figure out when assets changed last. This PR addsget_state_info, which serves the timestamp of the last modification, and the state hash if it is currently known.How Has This Been Tested?
Tested manually
Checklist: